linux-kernel - Re: [PATCH 1/1] thermal/drivers/imx_sc_thermal: Use dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8423953.T7Z3S40VBb@steina-w>
Date: Wed, 04 Sep 2024 13:48:55 +0200
From: Alexander Stein <alexander.stein@...tq-group.com>
To: "Rafael J. Wysocki" <rafael@...nel.org>, Daniel Lezcano <daniel.lezcano@...aro.org>, Zhang Rui <rui.zhang@...el.com>, Lukasz Luba <lukasz.luba@....com>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>
Cc: linux-pm@...r.kernel.org, imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] thermal/drivers/imx_sc_thermal: Use dev_err_probe

Hi,

Am Mittwoch, 17. Juli 2024, 10:55:16 CEST schrieb Alexander Stein:
> This adds the error code to the error message and also stores that
> message in case of probe deferral.
> 
> Signed-off-by: Alexander Stein <alexander.stein@...tq-group.com>
> ---
>  drivers/thermal/imx_sc_thermal.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c
> index 7224f8d21db97..88558ce588807 100644
> --- a/drivers/thermal/imx_sc_thermal.c
> +++ b/drivers/thermal/imx_sc_thermal.c
> @@ -111,8 +111,7 @@ static int imx_sc_thermal_probe(struct platform_device *pdev)
>  			if (ret == -ENODEV)
>  				continue;
>  
> -			dev_err(&pdev->dev, "failed to register thermal zone\n");
> -			return ret;
> +			return dev_err_probe(&pdev->dev, ret, "failed to register thermal zone\n");
>  		}
>  
>  		devm_thermal_add_hwmon_sysfs(&pdev->dev, sensor->tzd);
> 

Ping! Any feedback?

Thanks,
Alexander
-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/