linux-kernel - Re: [PATCH 2/8] pinctrl: Add driver for the T-Head TH1520 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbZtMcfv8anZZywC_5LoF-8X2dPW9ft489smrw9=hpcSQ@mail.gmail.com>
Date: Thu, 5 Sep 2024 15:12:50 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Drew Fustini <dfustini@...storrent.com>
Cc: Drew Fustini <drew@...7.com>, Guo Ren <guoren@...nel.org>, Fu Wei <wefu@...hat.com>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Emil Renner Berthing <emil.renner.berthing@...onical.com>, 
	Thomas Bonnefille <thomas.bonnefille@...tlin.com>, Paul Walmsley <paul.walmsley@...ive.com>, 
	Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>, 
	linux-riscv@...ts.infradead.org, linux-gpio@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/8] pinctrl: Add driver for the T-Head TH1520 SoC

Hi Drew,

thanks for your patch!

On Tue, Sep 3, 2024 at 6:08 AM Drew Fustini <dfustini@...storrent.com> wrote:

> From: Emil Renner Berthing <emil.renner.berthing@...onical.com>
>
> Add pinctrl driver for the T-Head TH1520 RISC-V SoC.
>
> Tested-by: Thomas Bonnefille <thomas.bonnefille@...tlin.com>
> Signed-off-by: Emil Renner Berthing <emil.renner.berthing@...onical.com>
> [dfustini: check unit address to identify the pin controller instance]
> Signed-off-by: Drew Fustini <dfustini@...storrent.com>

Overall the patch is in merge quality state, I just want the DT
people to tell how we are to handle the groups. I personally
would prefer a custom property over the unit name but let's
see what they say.

Yours,
Linus Walleij