[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240905154928.18fc7f10@fedora.home>
Date: Thu, 5 Sep 2024 15:49:28 +0200
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>
Cc: <netdev@...r.kernel.org>, <davem@...emloft.net>,
<linux@...linux.org.uk>, <kuba@...nel.org>, <andrew@...n.ch>,
<hkallweit1@...il.com>, <richardcochran@...il.com>,
<rdunlap@...radead.org>, <bryan.whitehead@...rochip.com>,
<edumazet@...gle.com>, <pabeni@...hat.com>, <linux-kernel@...r.kernel.org>,
<horms@...nel.org>, <UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH net-next V5 4/5] net: lan743x: Migrate phylib to phylink
Hello Raju,
On Wed, 4 Sep 2024 14:36:44 +0530
Raju Lakkaraju <Raju.Lakkaraju@...rochip.com> wrote:
> Migrate phy support from phylib to phylink.
>
> Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>
> ---
> Change List:
> ============
> V4 -> V5:
> - Remove the fixed_phy_unregister( ) function. Not require
> V3 -> V4:
> - Add the Fixed-link by include the Russell King patch
> - Change lan743x_phylink_create( ) argument from netdev to adapter
> V2 -> V3:
> - Remove the unwanted parens in each of these if() sub-blocks
> - Replace "to_net_dev(config->dev)" with "netdev".
> - Add GMII_ID/RGMII_TXID/RGMII_RXID in supported_interfaces
> - Fix the lan743x_phy_handle_exists( ) return type
> V1 -> V2:
> - Split the PHYLINK and SFP changes in 2 different patch series
Besides what Andrew pointed out, I don't see any obvious problem.
With Andrew's comments taken into account,
Reviewed-by: Maxime Chevallier <maxime.chevallier@...tlin.com>
Thanks,
Maxime
Powered by blists - more mailing lists