linux-kernel - Re: [PATCH -v2] Resource: fix region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87tteu6c01.fsf@yhuang6-desk2.ccr.corp.intel.com>
Date: Thu, 05 Sep 2024 11:00:14 +0800
From: "Huang, Ying" <ying.huang@...el.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,  <linux-mm@...ck.org>,
  <linux-kernel@...r.kernel.org>,  <linux-cxl@...r.kernel.org>,  Dan
 Williams <dan.j.williams@...el.com>,  David Hildenbrand
 <david@...hat.com>,  "Davidlohr Bueso" <dave@...olabs.net>,  Jonathan
 Cameron <jonathan.cameron@...wei.com>,  Dave Jiang <dave.jiang@...el.com>,
  Alison Schofield <alison.schofield@...el.com>,  Vishal Verma
 <vishal.l.verma@...el.com>,  "Ira Weiny" <ira.weiny@...el.com>,  Alistair
 Popple <apopple@...dia.com>,  "Bjorn Helgaas" <bhelgaas@...gle.com>,
  Baoquan He <bhe@...hat.com>
Subject: Re: [PATCH -v2] Resource: fix region_intersects() for CXL memory

Andy Shevchenko <andriy.shevchenko@...ux.intel.com> writes:

> On Wed, Sep 04, 2024 at 03:48:44PM +0800, Huang, Ying wrote:
>> Andy Shevchenko <andriy.shevchenko@...ux.intel.com> writes:
>> > On Mon, Aug 19, 2024 at 10:34:13AM +0800, Huang Ying wrote:
>

[snip]

>
>> >> +		ostart = max(res.start, p->start);
>> >> +		oend = min(res.end, p->end);
>> >
>> > Isn't a reinvention of resource_intersection()? With that in place you may also
>> > drop the above resource_overlaps().
>> 
>> sizeof(struct resource) == 8 * sizeof(unsigned long)
>> 
>> Just want to avoid to define another struct resource on stack.
>
> Is it a problem?

Not a serious problem.  Just prefer to avoid too much stack usage.
IMHO, the benefit isn't large too.

--
Best Regards,
Huang, Ying