linux-kernel - Re: [PATCH v2] usb: typec: tcpci: support edge irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240905142554.GA40671@francesco-nb>
Date: Thu, 5 Sep 2024 16:25:54 +0200
From: Francesco Dolcini <francesco@...cini.it>
To: Parth Pancholi <parth105105@...il.com>
Cc: Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Emanuele Ghidoli <emanuele.ghidoli@...adex.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Parth Pancholi <parth.pancholi@...adex.com>
Subject: Re: [PATCH v2] usb: typec: tcpci: support edge irq

On Thu, Sep 05, 2024 at 08:53:28AM +0200, Parth Pancholi wrote:
> From: Emanuele Ghidoli <emanuele.ghidoli@...adex.com>
> 
> TCPCI USB PHY - PTN5110 could be used with SOCs that only support
> the edge-triggered GPIO interrupts such as TI's K3 device AM69.
> Move the interrupt configuration to the firmware which would
> allow to accommodate edge triggered interrupts for such SOCs.
> In order to support the edge interrupts, register irq line in advance
> and keep track of occurrence during port registering.
> 
> When the edge interrupts are used, it is observed that some of the
> interrupts are missed when tcpci_irq() is serving the current
> interrupt. Therefore, check the status register at the end of
> tcpci_irq() and re-run the function if the status is not clear
> i.e. pending interrupt.
> 
> Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@...adex.com>
> Signed-off-by: Parth Pancholi <parth.pancholi@...adex.com>

Reviewed-by: Francesco Dolcini <francesco.dolcini@...adex.com>