lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e477ba59-36e8-4021-b32c-4db10fccea6e@microchip.com>
Date: Thu, 5 Sep 2024 16:37:01 +0200
From: Nicolas Ferre <nicolas.ferre@...rochip.com>
To: Andrei Simion <andrei.simion@...rochip.com>, <claudiu.beznea@...on.dev>,
	<alexandre.belloni@...tlin.com>, <robh@...nel.org>, <krzk+dt@...nel.org>,
	<conor+dt@...nel.org>
CC: <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
	<devicetree@...r.kernel.org>
Subject: Re: [PATCH] ARM: dts: microchip: sam9x60: Add missing property
 atmel,usart-mode

On 05/09/2024 at 11:30, Andrei Simion wrote:
> ~: make dtbs_check DT_SCHEMA_FILES=atmel,at91-usart.ymal
> -> for all boards which inherit sam9x60.dtsi: serial@200: $nodename:0:
> 'serial@...' does not match '^spi(@.*|-([0-9]|[1-9][0-9]+))?$
> serial@200: atmel,use-dma-rx: False schema does not allow True
> serial@200: atmel,use-dma-tx: False schema does not allow True
> serial@200: atmel,fifo-size: False schema does not allow [[16]]
> -> Means : atmel,usart-mode = <AT91_USART_MODE_SERIAL> misses for uart:
> 0,1,2,3,4,6,7,8,9,10,11,12
> 
> Add to uart nodes the property atmel,usart-mode to specify the driver to be
> used in serial mode to be compliant to atmel,at91-usart.yaml.
> 
> Fixes: 99c808335877 ("ARM: dts: at91: sam9x60: Add missing flexcom definitions")
> Signed-off-by: Andrei Simion <andrei.simion@...rochip.com>

Thanks Andrei:
Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

Best regards,
   Nicolas

> ---
>   arch/arm/boot/dts/microchip/sam9x60.dtsi | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/microchip/sam9x60.dtsi b/arch/arm/boot/dts/microchip/sam9x60.dtsi
> index 04a6d716ecaf..0ba424bba7cc 100644
> --- a/arch/arm/boot/dts/microchip/sam9x60.dtsi
> +++ b/arch/arm/boot/dts/microchip/sam9x60.dtsi
> @@ -174,6 +174,7 @@ flx4: flexcom@...00000 {
>   				uart4: serial@200 {
>   					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
>   					reg = <0x200 0x200>;
> +					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
>   					interrupts = <13 IRQ_TYPE_LEVEL_HIGH 7>;
>   					dmas = <&dma0
>   						(AT91_XDMAC_DT_MEM_IF(0) |
> @@ -376,6 +377,7 @@ flx11: flexcom@...20000 {
>   				uart11: serial@200 {
>   					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
>   					reg = <0x200 0x200>;
> +					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
>   					interrupts = <32 IRQ_TYPE_LEVEL_HIGH 7>;
>   					dmas = <&dma0
>   						(AT91_XDMAC_DT_MEM_IF(0) |
> @@ -427,6 +429,7 @@ flx12: flexcom@...24000 {
>   				uart12: serial@200 {
>   					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
>   					reg = <0x200 0x200>;
> +					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
>   					interrupts = <33 IRQ_TYPE_LEVEL_HIGH 7>;
>   					dmas = <&dma0
>   						(AT91_XDMAC_DT_MEM_IF(0) |
> @@ -586,6 +589,7 @@ flx6: flexcom@...10000 {
>   				uart6: serial@200 {
>   					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
>   					reg = <0x200 0x200>;
> +					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
>   					interrupts = <9 IRQ_TYPE_LEVEL_HIGH 7>;
>   					dmas = <&dma0
>   						(AT91_XDMAC_DT_MEM_IF(0) |
> @@ -637,6 +641,7 @@ flx7: flexcom@...14000 {
>   				uart7: serial@200 {
>   					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
>   					reg = <0x200 0x200>;
> +					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
>   					interrupts = <10 IRQ_TYPE_LEVEL_HIGH 7>;
>   					dmas = <&dma0
>   						(AT91_XDMAC_DT_MEM_IF(0) |
> @@ -688,6 +693,7 @@ flx8: flexcom@...18000 {
>   				uart8: serial@200 {
>   					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
>   					reg = <0x200 0x200>;
> +					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
>   					interrupts = <11 IRQ_TYPE_LEVEL_HIGH 7>;
>   					dmas = <&dma0
>   						(AT91_XDMAC_DT_MEM_IF(0) |
> @@ -739,6 +745,7 @@ flx0: flexcom@...1c000 {
>   				uart0: serial@200 {
>   					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
>   					reg = <0x200 0x200>;
> +					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
>   					interrupts = <5 IRQ_TYPE_LEVEL_HIGH 7>;
>   					dmas = <&dma0
>   						(AT91_XDMAC_DT_MEM_IF(0) |
> @@ -809,6 +816,7 @@ flx1: flexcom@...20000 {
>   				uart1: serial@200 {
>   					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
>   					reg = <0x200 0x200>;
> +					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
>   					interrupts = <6 IRQ_TYPE_LEVEL_HIGH 7>;
>   					dmas = <&dma0
>   						(AT91_XDMAC_DT_MEM_IF(0) |
> @@ -879,6 +887,7 @@ flx2: flexcom@...24000 {
>   				uart2: serial@200 {
>   					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
>   					reg = <0x200 0x200>;
> +					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
>   					interrupts = <7 IRQ_TYPE_LEVEL_HIGH 7>;
>   					dmas = <&dma0
>   						(AT91_XDMAC_DT_MEM_IF(0) |
> @@ -949,6 +958,7 @@ flx3: flexcom@...28000 {
>   				uart3: serial@200 {
>   					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
>   					reg = <0x200 0x200>;
> +					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
>   					interrupts = <8 IRQ_TYPE_LEVEL_HIGH 7>;
>   					dmas = <&dma0
>   						(AT91_XDMAC_DT_MEM_IF(0) |
> @@ -1074,6 +1084,7 @@ flx9: flexcom@...40000 {
>   				uart9: serial@200 {
>   					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
>   					reg = <0x200 0x200>;
> +					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
>   					interrupts = <15 IRQ_TYPE_LEVEL_HIGH 7>;
>   					dmas = <&dma0
>   						(AT91_XDMAC_DT_MEM_IF(0) |
> @@ -1125,6 +1136,7 @@ flx10: flexcom@...44000 {
>   				uart10: serial@200 {
>   					compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
>   					reg = <0x200 0x200>;
> +					atmel,usart-mode = <AT91_USART_MODE_SERIAL>;
>   					interrupts = <16 IRQ_TYPE_LEVEL_HIGH 7>;
>   					dmas = <&dma0
>   						(AT91_XDMAC_DT_MEM_IF(0) |
> 
> base-commit: fdadd93817f124fd0ea6ef251d4a1068b7feceba


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ