linux-kernel - Re: [PATCH net] net: mdiobus: Debug print fwnode handle instead of raw pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <710a17b0-576a-4b5b-89e8-35cc76681e8b@lunn.ch>
Date: Thu, 5 Sep 2024 16:52:05 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Alexander Dahl <ada@...rsis.com>
Cc: netdev@...r.kernel.org, Calvin Johnson <calvin.johnson@....nxp.com>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] net: mdiobus: Debug print fwnode handle instead of
 raw pointer

On Thu, Sep 05, 2024 at 04:32:47PM +0200, Alexander Dahl wrote:
> Was slightly misleading before, because printed is pointer to fwnode,
> not to phy device, as placement in message suggested.  Include header
> for dev_dbg() declaration while at it.
> 
> Output before:
> 
>     [  +0.001247] mdio_bus f802c000.ethernet-ffffffff: registered phy 2612f00a fwnode at address 3
> 
> Output after:
> 
>     [  +0.001229] mdio_bus f802c000.ethernet-ffffffff: registered phy fwnode /ahb/apb/ethernet@...2c000/ethernet-phy@3 at address 3
> 
> Signed-off-by: Alexander Dahl <ada@...rsis.com>

The patch itself looks good. But i think this should be for net-next,
not net. '2612f00a' is not particularly useful, but i don't think it
causes problems for anybody as required by the Stable rules.

So the Subject should be [PATCH net-next]

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew