linux-kernel - Re: [PATCH v3 1/2] ext4: Check stripe size compatibility on remount as well

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <172554793836.1268668.15514751262481415081.b4-ty@mit.edu>
Date: Thu,  5 Sep 2024 10:53:44 -0400
From: "Theodore Ts'o" <tytso@....edu>
To: linux-ext4@...r.kernel.org, Ojaswin Mujoo <ojaswin@...ux.ibm.com>
Cc: "Theodore Ts'o" <tytso@....edu>, Ritesh Harjani <ritesh.list@...il.com>,
        linux-kernel@...r.kernel.org, Kemeng Shi <shikemeng@...weicloud.com>,
        syzbot+1ad8bac5af24d01e2cbd@...kaller.appspotmail.com
Subject: Re: [PATCH v3 1/2] ext4: Check stripe size compatibility on remount as well


On Fri, 30 Aug 2024 12:50:57 +0530, Ojaswin Mujoo wrote:
> We disable stripe size in __ext4_fill_super if it is not a multiple of
> the cluster ratio however this check is missed when trying to remount.
> This can leave us with cases where stripe < cluster_ratio after
> remount:set making EXT4_B2C(sbi->s_stripe) become 0 that can cause some
> unforeseen bugs like divide by 0.
> 
> Fix that by adding the check in remount path as well.
> 
> [...]

Applied, thanks!

[1/2] ext4: Check stripe size compatibility on remount as well
      commit: ee85e0938aa8f9846d21e4d302c3cf6a2a75110d
[2/2] ext4: Convert EXT4_B2C(sbi->s_stripe) users to EXT4_NUM_B2C
      commit: ff2beee206d23f49d022650122f81285849033e4

Best regards,
-- 
Theodore Ts'o <tytso@....edu>