linux-kernel - Re: [PATCH] kunit: Fix missing kerneldoc comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ec735866-7074-47a6-afae-50ec287df7c8@linuxfoundation.org>
Date: Thu, 5 Sep 2024 09:31:04 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: David Gow <davidgow@...gle.com>,
 Brendan Higgins <brendan.higgins@...ux.dev>, Rae Moar <rmoar@...gle.com>,
 Kees Cook <kees@...nel.org>, Maxime Ripard <mripard@...nel.org>,
 Stephen Rothwell <sfr@...b.auug.org.au>
Cc: linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com,
 linux-kernel@...r.kernel.org, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] kunit: Fix missing kerneldoc comment

On 9/4/24 20:47, David Gow wrote:
> Add a missing kerneldoc comment for the 'test' test context parameter,
> fixing the following warning:
> 
> include/kunit/test.h:492: warning: Function parameter or struct member 'test' not described in 'kunit_kfree_const'
> 
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Closes: https://lore.kernel.org/lkml/20240827160631.67e121ed@canb.auug.org.au/
> Fixes: f2c6dbd22017 ("kunit: Device wrappers should also manage driver name")
> Signed-off-by: David Gow <davidgow@...gle.com>
> ---
>   include/kunit/test.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/include/kunit/test.h b/include/kunit/test.h
> index 5ac237c949a0..34b71e42fb10 100644
> --- a/include/kunit/test.h
> +++ b/include/kunit/test.h
> @@ -484,6 +484,7 @@ static inline void *kunit_kcalloc(struct kunit *test, size_t n, size_t size, gfp
>   
>   /**
>    * kunit_kfree_const() - conditionally free test managed memory
> + * @test: The test context object.
>    * @x: pointer to the memory
>    *
>    * Calls kunit_kfree() only if @x is not in .rodata section.

David,

I sent PR for 6.11-rc7 for the following since it is a critical
fix.

kunit: Device wrappers should also manage driver name

I will take this in once the pr clears applying for 6.12-rc1

thanks,
-- Shuah