linux-kernel - Re: [PATCH] platform: cznic: turris-omnia-mcu: Fix error check in omnia_mcu_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <csrrgt4lzrzgdbanq64lhgxklhfcn62f4lkdxfkwaoxxoexre2@33ccc3g4wbmy>
Date: Thu, 5 Sep 2024 18:07:41 +0200
From: Marek Behún <kabel@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Marek Behún <kabel@...nel.org>, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org, 
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] platform: cznic: turris-omnia-mcu: Fix error check in
 omnia_mcu_register_trng()

On Thu, Sep 05, 2024 at 04:16:53PM +0300, Dan Carpenter wrote:
> The gpiod_to_irq() function never returns zero.  It returns negative
> error codes or a positive IRQ number.  Update the checking to check
> for negatives.
> 
> Fixes: 41bb142a4028 ("platform: cznic: turris-omnia-mcu: Add support for MCU provided TRNG")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Marek Behún <kabel@...nel.org>