linux-kernel - Re: [PATCH] Date: Remove unused macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f22bc072-c8b0-405f-a4e6-da6213350c1a@linuxfoundation.org>
Date: Thu, 5 Sep 2024 10:08:27 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: zhangjiao2 <zhangjiao2@...s.chinamobile.com>, shuah@...nel.org
Cc: jstultz@...gle.com, tglx@...utronix.de, anna-maria@...utronix.de,
 frederic@...nel.org, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] Date: Remove unused macro

On 9/5/24 02:52, zhangjiao2 wrote:
> From: zhang jiao <zhangjiao2@...s.chinamobile.com>
> 
> This macro NSEC_PER_SEC is never referenced in the code.
> Just remove it.

Is this duplicate patch?

I think I commented on your patch on futex - include how
you found the problem in change logs. Also you have to
include subsystem prefix in the subject line:

selftests/timers: Remove unused NSEC_PER_SEC macro

I see another patch with similar problems from you.
Refer to submitting patches document in the kernel
repo.

> 
> Signed-off-by: zhang jiao <zhangjiao2@...s.chinamobile.com>
> ---
>   tools/testing/selftests/timers/change_skew.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/tools/testing/selftests/timers/change_skew.c b/tools/testing/selftests/timers/change_skew.c
> index 4421cd562c24..18e794a46c23 100644
> --- a/tools/testing/selftests/timers/change_skew.c
> +++ b/tools/testing/selftests/timers/change_skew.c
> @@ -30,9 +30,6 @@
>   #include <time.h>
>   #include "../kselftest.h"
>   
> -#define NSEC_PER_SEC 1000000000LL
> -
> -
>   int change_skew_test(int ppm)
>   {
>   	struct timex tx;

thanks,
-- Shuah