[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Ztnj40_A18uWiwU4@smile.fi.intel.com>
Date: Thu, 5 Sep 2024 20:01:23 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org,
llvm@...ts.linux.dev
Cc: Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
"H. Peter Anvin" <hpa@...or.com>,
Nathan Chancellor <nathan@...nel.org>,
Nick Desaulniers <ndesaulniers@...gle.com>,
Bill Wendling <morbo@...gle.com>,
Justin Stitt <justinstitt@...gle.com>
Subject: Re: [PATCH v1 1/1] x86/cpu: Mark flag_is_changeable_p() with
__maybe_unused
On Thu, Sep 05, 2024 at 07:58:58PM +0300, Andy Shevchenko wrote:
> When flag_is_changeable_p() is unused, it prevents kernel builds
> with clang, `make W=1` and CONFIG_WERROR=y:
>
> arch/x86/kernel/cpu/common.c:351:19: error: unused function 'flag_is_changeable_p' [-Werror,-Wunused-function]
> 351 | static inline int flag_is_changeable_p(u32 flag)
> | ^~~~~~~~~~~~~~~~~~~~
>
> Fix this by marking it with __maybe_unused.
>
> See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static
> inline functions for W=1 build").
...and it should be done for 64-bit case.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists