linux-kernel - Re: [PATCH v2 03/19] iommu: Pass in a viommu pointer to domain_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZtnoMJPdeb17Uj/e@nvidia.com>
Date: Thu, 5 Sep 2024 10:19:44 -0700
From: Nicolin Chen <nicolinc@...dia.com>
To: Jason Gunthorpe <jgg@...dia.com>
CC: <kevin.tian@...el.com>, <will@...nel.org>, <joro@...tes.org>,
	<suravee.suthikulpanit@....com>, <robin.murphy@....com>,
	<dwmw2@...radead.org>, <baolu.lu@...ux.intel.com>, <shuah@...nel.org>,
	<linux-kernel@...r.kernel.org>, <iommu@...ts.linux.dev>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-kselftest@...r.kernel.org>,
	<eric.auger@...hat.com>, <jean-philippe@...aro.org>, <mdf@...nel.org>,
	<mshavit@...gle.com>, <shameerali.kolothum.thodi@...wei.com>,
	<smostafa@...gle.com>, <yi.l.liu@...el.com>
Subject: Re: [PATCH v2 03/19] iommu: Pass in a viommu pointer to
 domain_alloc_user op

On Thu, Sep 05, 2024 at 12:54:54PM -0300, Jason Gunthorpe wrote:
> On Tue, Aug 27, 2024 at 09:59:40AM -0700, Nicolin Chen wrote:
> > With a viommu object wrapping a potentially shareable S2 domain, a nested
> > domain should be allocated by associating to a viommu instead. Driver can
> > store this viommu pointer somewhere, so as to later use it calling viommu
> > helpers for virtual device ID lookup and viommu invalidation.
> > 
> > For drivers without a viommu support, keep the parent domain input, which
> > should be just viommu->hwpt->common.domain otherwise.
> 
> I've been thinking of add an op for nested allocation since every
> driver immediately jumps to a special function for nested allocation
> anyhow without sharing any code.
> 
> Adding a new parameter that is nested only seems like a good point to
> try to do that..

Yea, it makes sense to have a domain_alloc_nested, for hwpt_nested
exclusively. Then domain_alloc_user would be for hwpt_paging only.

Thanks
Nicolin