linux-kernel - Re: [PATCH v2 16/21] dt-bindings: spi: document support for SA8255p

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1b72ee5e-544d-4f9e-8915-a5d9d0244c8f@lunn.ch>
Date: Thu, 5 Sep 2024 19:35:33 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Nikunj Kela <quic_nkela@...cinc.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, andersson@...nel.org,
	konradybcio@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, rafael@...nel.org, viresh.kumar@...aro.org,
	herbert@...dor.apana.org.au, davem@...emloft.net,
	sudeep.holla@....com, andi.shyti@...nel.org, tglx@...utronix.de,
	will@...nel.org, robin.murphy@....com, joro@...tes.org,
	jassisinghbrar@...il.com, lee@...nel.org, linus.walleij@...aro.org,
	amitk@...nel.org, thara.gopinath@...il.com, broonie@...nel.org,
	cristian.marussi@....com, rui.zhang@...el.com, lukasz.luba@....com,
	wim@...ux-watchdog.org, linux@...ck-us.net,
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
	linux-crypto@...r.kernel.org, arm-scmi@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-i2c@...r.kernel.org,
	iommu@...ts.linux.dev, linux-gpio@...r.kernel.org,
	linux-serial@...r.kernel.org, linux-spi@...r.kernel.org,
	linux-watchdog@...r.kernel.org, kernel@...cinc.com,
	quic_psodagud@...cinc.com,
	Praveen Talari <quic_ptalari@...cinc.com>
Subject: Re: [PATCH v2 16/21] dt-bindings: spi: document support for SA8255p

On Thu, Sep 05, 2024 at 09:39:54AM -0700, Nikunj Kela wrote:
> 
> On 9/5/2024 9:23 AM, Andrew Lunn wrote:
> >> If the QUPs yaml changes are not included in the same series with
> >> i2c,serial yaml changes, you see these errors:
> >>
> >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.example.dtb: geniqup@...000: serial@...000:compatible:0: 'qcom,sa8255p-geni-uart' is not one of ['qcom,geni-uart', 'qcom,geni-debug-uart']
> >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.example.dtb: geniqup@...000: i2c@...000:compatible:0: 'qcom,sa8255p-geni-i2c' is not one of ['qcom,geni-i2c', 'qcom,geni-i2c-master-hub']
> > So you have a couple of options:
> >
> > 1) It sounds like you should get the QUP changes merged first. Then
> >    submit the i2c,serial changes. Is there a reason you cannot do
> >    this? Is there a mutual dependency between these two series, or
> >    just a one way dependency?
> 
> The ask in this thread is to create new yaml files since existing one is
> using generic compatibles. With new yaml, we would need to provide
> example and can't avoid it. If we have to provide example of QUP node,
> IMO, we should provide a few subnodes as well since just QUP node
> without subnodes(i2c/serial/spi)  will not be very useful.

Does it need to be useful, at the beginning? Was the development done
all at once, i2c, serial and spi all mixed together, inseparable? More
likely, you have a set of patches adding some sort of base, and
hopefully a DT binding patch for that base. Then you add a driver in
drivers/tty/serial, with patches which extend the DT binding with the
serial port. You then add a driver in driver/i2c/busses and extend the
DT binding for I2C. And then add a driver for SPI in drivers/spi,
which again extends the DT binding?

This would be typical for how an MFD would be posted. Please go search
the lists for examples of MFDs you might be able to follow.

	Andrew