linux-kernel - Re: [PATCH v2 2/2] x86/sgx: Log information when a node lacks an EPC section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <585f9b58-3506-499e-ab9f-6076f2e83ef5@intel.com>
Date: Thu, 5 Sep 2024 12:02:09 -0700
From: Dave Hansen <dave.hansen@...el.com>
To: Jarkko Sakkinen <jarkko@...nel.org>, Aaron Lu <aaron.lu@...el.com>,
 Dave Hansen <dave.hansen@...ux.intel.com>, Kai Huang <kai.huang@...el.com>
Cc: "Molina Sabido, Gerardo" <gerardo.molina.sabido@...el.com>,
 Zhimin Luo <zhimin.luo@...el.com>, linux-sgx@...r.kernel.org,
 linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH v2 2/2] x86/sgx: Log information when a node lacks an EPC
 section

On 9/5/24 07:24, Jarkko Sakkinen wrote:
>> +	for_each_online_node(nid) {
>> +		if (!node_isset(nid, sgx_numa_mask) &&
>> +		    node_state(nid, N_MEMORY) && node_state(nid, N_CPU))
>> +			pr_info("node%d has both CPUs and memory but doesn't have an EPC section\n",
>> +				nid);
> Is this enough, or is there anything that would need to be done
> automatically if this happens? With a tracepoint you could react to such
> even but I'm totally fine with this.

There's always the theoretical chance that there are nodes being
hotplugged or that this is all running in a VM that has some whacky
topology.

But this simple pr_info() provides good coverage for the common cases
and shouldn't be too much of a burden for the weridos.