linux-kernel - Re: [RFC 31/31] objtool, livepatch: Livepatch module generation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240905041554.2kgnwuiketn2rrdw@treble>
Date: Wed, 4 Sep 2024 21:15:54 -0700
From: Josh Poimboeuf <jpoimboe@...nel.org>
To: Jeff Johnson <quic_jjohnson@...cinc.com>
Cc: live-patching@...r.kernel.org, linux-kernel@...r.kernel.org,
	x86@...nel.org, Miroslav Benes <mbenes@...e.cz>,
	Petr Mladek <pmladek@...e.com>,
	Joe Lawrence <joe.lawrence@...hat.com>,
	Jiri Kosina <jikos@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Marcos Paulo de Souza <mpdesouza@...e.com>,
	Song Liu <song@...nel.org>
Subject: Re: [RFC 31/31] objtool, livepatch: Livepatch module generation

On Wed, Sep 04, 2024 at 02:38:14PM -0700, Jeff Johnson wrote:
> On 9/2/24 21:00, Josh Poimboeuf wrote:
> ...
> > diff --git a/scripts/livepatch/module.c b/scripts/livepatch/module.c
> > new file mode 100644
> > index 000000000000..101cabf6b2f1
> > --- /dev/null
> > +++ b/scripts/livepatch/module.c
> > @@ -0,0 +1,120 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later
> > +/*
> > + * Base module code for a livepatch kernel module
> > + *
> > + * Copyright (C) 2024 Josh Poimboeuf <jpoimboe@...nel.org>
> > + */
> ...
> > +module_init(livepatch_mod_init);
> > +module_exit(livepatch_mod_exit);
> > +MODULE_LICENSE("GPL");
> > +MODULE_INFO(livepatch, "Y");
> 
> Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
> description is missing"), a module without a MODULE_DESCRIPTION() will
> result in a warning when built with make W=1. Recently, multiple
> developers have been eradicating these warnings treewide, and very few
> are left. Not sure if this would introduce a new one, so just want to
> flag it so that you can check and fix if necessary.

I'll fix that, thanks!

-- 
Josh