[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7hseudahla.fsf@baylibre.com>
Date: Thu, 05 Sep 2024 14:58:09 -0700
From: Kevin Hilman <khilman@...libre.com>
To: Ulf Hansson <ulf.hansson@...aro.org>
Cc: linux-pm@...r.kernel.org, Nishanth Menon <nm@...com>, Vibhore Vardhan
<vibhore@...com>, Dhruva Gole <d-gole@...com>, Akashdeep Kaur
<a-kaur@...com>, Sebin Francis <sebin.francis@...com>, Markus
Schneider-Pargmann <msp@...libre.com>,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] pmdomain: ti_sci: add wakeup constraint management
Ulf Hansson <ulf.hansson@...aro.org> writes:
> On Tue, 20 Aug 2024 at 02:00, Kevin Hilman <khilman@...libre.com> wrote:
>>
>> During system-wide suspend, check all devices connected to PM domain
>> to see if they are wakeup-enabled. If so, set a TI SCI device
>> constraint.
>>
>> Note: DM firmware clears all constraints on resume.
>>
>> Co-developed-by: Vibhore Vardhan <vibhore@...com>
>> Signed-off-by: Vibhore Vardhan <vibhore@...com>
>> Signed-off-by: Kevin Hilman <khilman@...libre.com>
>> Signed-off-by: Dhruva Gole <d-gole@...com>
>> ---
>> drivers/pmdomain/ti/ti_sci_pm_domains.c | 19 +++++++++++++++++++
>> 1 file changed, 19 insertions(+)
>>
>> diff --git a/drivers/pmdomain/ti/ti_sci_pm_domains.c b/drivers/pmdomain/ti/ti_sci_pm_domains.c
>> index 963272fa387b..8af907579152 100644
>> --- a/drivers/pmdomain/ti/ti_sci_pm_domains.c
>> +++ b/drivers/pmdomain/ti/ti_sci_pm_domains.c
>> @@ -76,6 +76,23 @@ static int ti_sci_pd_set_lat_constraint(struct device *dev, s32 val)
>> return ret;
>> }
>>
>> +static inline bool ti_sci_pd_set_wkup_constraint(struct device *dev)
>> +{
>
> Similar comment as for patch1, should this be a static void intstead?
>
Yes, will do in v3.
Kevin
Powered by blists - more mailing lists