[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f8a5018f-113d-4d9d-9223-954d054796a6@classfun.cn>
Date: Thu, 5 Sep 2024 13:37:17 +0800
From: Junhao Xie <bigfoot@...ssfun.cn>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>,
Jonas Karlman <jonas@...boo.se>, Chukun Pan <amadeus@....edu.cn>,
FUKAUMI Naoki <naoki@...xa.com>, Dragan Simic <dsimic@...jaro.org>,
linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
Junhao Xie <bigfoot@...ssfun.cn>
Subject: Re: [PATCH 0/3] Add support for Ariaboard Photonicat RK3568
On 2024/9/4 21:36, Rob Herring (Arm) wrote> On Wed, 04 Sep 2024 19:14:53 +0800, Junhao Xie wrote:
>> Add dts for Ariaboard Photonicat RK3568.
>>
[...]
>
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
>
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
>
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
>
> pip3 install dtschema --upgrade
>
>
> New warnings running 'make CHECK_DTBS=y rockchip/rk3568-ariaboard-photonicat.dtb' for 20240904111456.87089-1-bigfoot@...ssfun.cn:
>
> arch/arm64/boot/dts/rockchip/rk3568-ariaboard-photonicat.dtb: phy@...c0000: 'phy-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/phy/rockchip,pcie3-phy.yaml#
I will remove it in PATCH v2
> arch/arm64/boot/dts/rockchip/rk3568-ariaboard-photonicat.dtb: rfkill-modem: 'reset-gpios' does not match any of the regexes: 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/net/rfkill-gpio.yaml#
The modem in Photonicat must have a reset signal to work properly.
I can find reset-gpios in net/rfkill/rfkill-gpio.c, but it is not in the schema.
Maybe reset-gpios is missing in rfkill-gpio.yaml? or this property cannot be used in dts?
>
Thanks for your reply, I will fix them in PATCH v2.
Best regards,
Junhao
Powered by blists - more mailing lists