linux-kernel - Re: [PATCH v4 1/3] dt-bindings: net: ti,cc1352p7: Add bootloader-backdoor-gpios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240905062306.lm4jgr7yp2enldt3@lcpd911>
Date: Thu, 5 Sep 2024 11:53:06 +0530
From: Dhruva Gole <d-gole@...com>
To: Ayush Singh <ayush@...gleboard.org>
CC: <lorforlinux@...gleboard.org>, <jkridner@...gleboard.org>,
        <robertcnelson@...gleboard.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo
 Abeni <pabeni@...hat.com>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, Nishanth Menon
	<nm@...com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Tero Kristo
	<kristo@...nel.org>, Johan Hovold <johan@...nel.org>,
        Alex Elder
	<elder@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <greybus-dev@...ts.linaro.org>, <netdev@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        Conor Dooley
	<conor.dooley@...rochip.com>
Subject: Re: [PATCH v4 1/3] dt-bindings: net: ti,cc1352p7: Add
 bootloader-backdoor-gpios

On Sep 03, 2024 at 15:02:18 +0530, Ayush Singh wrote:
> bootloader-backdoor-gpio (along with reset-gpio) is used to enable
> bootloader backdoor for flashing new firmware.
> 
> The pin and pin level to enable bootloader backdoor is configured using
> the following CCFG variables in cc1352p7:
> - SET_CCFG_BL_CONFIG_BL_PIN_NO
> - SET_CCFG_BL_CONFIG_BL_LEVEL
> 
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> Acked-by: Rob Herring (Arm) <robh@...nel.org>
> Signed-off-by: Ayush Singh <ayush@...gleboard.org>
> ---
>  Documentation/devicetree/bindings/net/ti,cc1352p7.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml
> index 3dde10de4630..4f4253441547 100644
> --- a/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml
> +++ b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml
> @@ -29,6 +29,12 @@ properties:
>    reset-gpios:
>      maxItems: 1
>  
> +  bootloader-backdoor-gpios:
> +    maxItems: 1
> +    description: |
> +      gpios to enable bootloader backdoor in cc1352p7 bootloader to allow
> +      flashing new firmware.
> +
>    vdds-supply: true
>  
>  required:
> @@ -46,6 +52,7 @@ examples:
>          clocks = <&sclk_hf 0>, <&sclk_lf 25>;
>          clock-names = "sclk_hf", "sclk_lf";
>          reset-gpios = <&pio 35 GPIO_ACTIVE_LOW>;
> +        bootloader-backdoor-gpios = <&pio 36 GPIO_ACTIVE_LOW>;

Did you mean &gpio here and even in reset part?
Looks good otherwise,
Reviewed-by: Dhruva Gole <d-gole@...com>

-- 
Best regards,
Dhruva Gole
Texas Instruments Incorporated