linux-kernel - Re: [PATCH] mm: vmscan.c: fix OOM on swap stress test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d69cc5a5-ac69-4b43-82fa-391eb7a17cbd@leemhuis.info>
Date: Thu, 5 Sep 2024 08:53:55 +0200
From: Thorsten Leemhuis <regressions@...mhuis.info>
To: Yu Zhao <yuzhao@...gle.com>, Chris Li <chrisl@...nel.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>, yangge <yangge1116@....com>,
 David Hildenbrand <david@...hat.com>, Hugh Dickins <hughd@...gle.com>,
 baolin.wang@...ux.alibaba.com, Kairui Song <ryncsn@...il.com>,
 linux-mm@...ck.org, linux-kernel@...r.kernel.org,
 Linux kernel regressions list <regressions@...ts.linux.dev>
Subject: Re: [PATCH] mm: vmscan.c: fix OOM on swap stress test



On 05.09.24 08:42, Yu Zhao wrote:
> On Thu, Sep 5, 2024 at 12:21 AM Chris Li <chrisl@...nel.org> wrote:
>>
>> I found a regression on mm-unstable during my swap stress test,
>> using tmpfs to compile linux. The test OOM very soon after
>> the make spawns many cc processes.
>>
>> It bisects down to this change: 33dfe9204f29b415bbc0abb1a50642d1ba94f5e9
>> (mm/gup: clear the LRU flag of a page before adding to LRU batch)
>>
>> Yu Zhao propose the fix: "I think this is one of the potential side
>> effects -- Huge mentioned earlier about isolate_lru_folios():"
>>
>> I test that with it the swap stress test no longer OOM.
>>
>> Link: https://lore.kernel.org/r/CAOUHufYi9h0kz5uW3LHHS3ZrVwEq-kKp8S6N-MZUmErNAXoXmw@mail.gmail.com/
>> Fixes: 33dfe9204f29 ("mm/gup: clear the LRU flag of a page before adding to LRU batch")
>> Suggested-by: Yu Zhao <yuzhao@...gle.com>
>> Suggested-by: Hugh Dickins <hughd@...gle.com>
>> Tested-by: Chris Li <chrisl@...nel.org>
>> Signed-off-by: Chris Li <chrisl@...nel.org>

Thx for taking care of this, Chris!

> Closes: https://lore.kernel.org/56651be8-1466-475f-b1c5-4087995cc5ae@leemhuis.info/

FWIW, no big deal, but that ideally should be (in general and for
regression tracking) the following instead, as that link above is just
at the end of the thread with the report, but not the report itself --
and that is what often needed when someone needs to look up the
backstory of this chance sooner or later:

Closes:
https://lore.kernel.org/all/CAF8kJuNP5iTj2p07QgHSGOJsiUfYpJ2f4R1Q5-3BN9JiD9W_KA@mail.gmail.com/

Ciao, Thorsten