linux-kernel - Re: [PATCH] iio/inv_icm42600: add inv_icm42600 id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <FR3P281MB1757BEA60FF72A44847F1646CE9D2@FR3P281MB1757.DEUP281.PROD.OUTLOOK.COM>
Date: Thu, 5 Sep 2024 09:25:33 +0000
From: Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@....com>
To: jason liu <jasonliu10041728@...il.com>
CC: "jic23@...nel.org" <jic23@...nel.org>,
        "lars@...afoo.de"
	<lars@...afoo.de>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio/inv_icm42600: add inv_icm42600 id_table

Hello,

looks good for me now, thanks for the patch.

Acked-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@....com>

Thanks,
JB

________________________________________
From: jason liu <jasonliu10041728@...il.com>
Sent: Wednesday, September 4, 2024 11:00
To: Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@....com>
Cc: jic23@...nel.org <jic23@...nel.org>; lars@...afoo.de <lars@...afoo.de>; linux-iio@...r.kernel.org <linux-iio@...r.kernel.org>; linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio/inv_icm42600: add inv_icm42600 id_table
 
This Message Is From an Untrusted Sender
You have not previously corresponded with this sender.
 
Hello, does patch v3 meet the requirements?

BR.

Jason Liu <jasonliu10041728@...il.com> 于2024年9月2日周一 19:31写道：
Add the id_table of inv_icm42600, so the device can probe correctly.

Signed-off-by: Jason Liu <jasonliu10041728@...il.com>
---
V1->V2: fix up the formatting as requested
---
V2->V3: add icm42686 (INV_ICM_42686) and icm42688 (INV_ICM_42688)
---
 drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c | 17 +++++++++++++++++
 drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c | 17 +++++++++++++++++
 2 files changed, 34 insertions(+)

diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c
index ebb31b385881..9e65fef04c39 100644
--- a/drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c
+++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c
@@ -71,6 +71,22 @@ static int inv_icm42600_probe(struct i2c_client *client)
                                       inv_icm42600_i2c_bus_setup);
 }

+/*
+ * device id table is used to identify what device can be
+ * supported by this driver
+ */
+static const struct i2c_device_id inv_icm42600_id[] = {
+       { "icm42600", INV_CHIP_ICM42600 },
+       { "icm42602", INV_CHIP_ICM42602 },
+       { "icm42605", INV_CHIP_ICM42605 },
+       { "icm42686", INV_CHIP_ICM42686 },
+       { "icm42622", INV_CHIP_ICM42622 },
+       { "icm42688", INV_CHIP_ICM42688 },
+       { "icm42631", INV_CHIP_ICM42631 },
+       {}
+};
+MODULE_DEVICE_TABLE(i2c, inv_icm42600_id);
+
 static const struct of_device_id inv_icm42600_of_matches[] = {
        {
                .compatible = "invensense,icm42600",
@@ -104,6 +120,7 @@ static struct i2c_driver inv_icm42600_driver = {
                .of_match_table = inv_icm42600_of_matches,
                .pm = pm_ptr(&inv_icm42600_pm_ops),
        },
+       .id_table = inv_icm42600_id,
        .probe = inv_icm42600_probe,
 };
 module_i2c_driver(inv_icm42600_driver);
diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c
index eae5ff7a3cc1..75441b2be174 100644
--- a/drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c
+++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c
@@ -67,6 +67,22 @@ static int inv_icm42600_probe(struct spi_device *spi)
                                       inv_icm42600_spi_bus_setup);
 }

+/*
+ * device id table is used to identify what device can be
+ * supported by this driver
+ */
+static const struct spi_device_id inv_icm42600_id[] = {
+       { "icm42600", INV_CHIP_ICM42600 },
+       { "icm42602", INV_CHIP_ICM42602 },
+       { "icm42605", INV_CHIP_ICM42605 },
+       { "icm42686", INV_CHIP_ICM42686 },
+       { "icm42622", INV_CHIP_ICM42622 },
+       { "icm42688", INV_CHIP_ICM42688 },
+       { "icm42631", INV_CHIP_ICM42631 },
+       {}
+};
+MODULE_DEVICE_TABLE(spi, inv_icm42600_id);
+
 static const struct of_device_id inv_icm42600_of_matches[] = {
        {
                .compatible = "invensense,icm42600",
@@ -100,6 +116,7 @@ static struct spi_driver inv_icm42600_driver = {
                .of_match_table = inv_icm42600_of_matches,
                .pm = pm_ptr(&inv_icm42600_pm_ops),
        },
+       .id_table = inv_icm42600_id,
        .probe = inv_icm42600_probe,
 };
 module_spi_driver(inv_icm42600_driver);
--
2.25.1