linux-kernel - Re: [PATCH 6.6 1/1] PM: sleep: Restore asynchronous device resume optimization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240905093433.4798-1-yenchia.chen@mediatek.com>
Date: Thu, 5 Sep 2024 17:34:33 +0800
From: Yenchia Chen <yenchia.chen@...iatek.com>
To: <gregkh@...uxfoundation.org>
CC: <angelogioacchino.delregno@...labora.com>, <len.brown@...el.com>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
	<linux-mediatek@...ts.infradead.org>, <linux-pm@...r.kernel.org>,
	<matthias.bgg@...il.com>, <pavel@....cz>, <rafael.j.wysocki@...el.com>,
	<rafael@...nel.org>, <stable@...r.kernel.org>, <yenchia.chen@...iatek.com>
Subject: Re: [PATCH 6.6 1/1] PM: sleep: Restore asynchronous device resume optimization

>> From: "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
>> 
>> commit 3e999770ac1c7c31a70685dd5b88e89473509e9c upstream.
>> 
>> Before commit 7839d0078e0d ("PM: sleep: Fix possible deadlocks in core
>> system-wide PM code"), the resume of devices that were allowed to resume
>> asynchronously was scheduled before starting the resume of the other
>> devices, so the former did not have to wait for the latter unless
>> functional dependencies were present.
>> 
>> Commit 7839d0078e0d removed that optimization in order to address a
>> correctness issue, but it can be restored with the help of a new device
>> power management flag, so do that now.
>> 
>> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
>> Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@...ux.intel.com>
>> Signed-off-by: Yenchia Chen <yenchia.chen@...iatek.com>
>> ---
>>  drivers/base/power/main.c | 117 +++++++++++++++++++++-----------------
>>  include/linux/pm.h        |   1 +
>>  2 files changed, 65 insertions(+), 53 deletions(-)

>Why does this need to be backported?  What bug is it fixing?

>confused,

>greg k-h

Below is the scenario we met the issue:
1) use command 'echo 3 > /proc/sys/vm/drop_caches'
   and enter suspending stage immediately.
2) power on device, our driver try to read mmc after leaving resume callback
   and got stucked.

We found if we did not drop caches, mmc_blk_resume will be called and
system works fine.

If we drop caches before suspending, there is a high possibility that
mmc_blk_resume not be called and our driver stucked at filp_open.

We still try to find the root casue is but with this patch, it works.

Since it has been merged in mainline, we'd like to know it is ok to merge to stable.