[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAPDyKFp1iOUdp=pL_xpP0DNu24Z-wC5SYhwzNy5CcEkz3XWWyA@mail.gmail.com>
Date: Thu, 5 Sep 2024 12:18:26 +0200
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Detlev Casanova <detlev.casanova@...labora.com>
Cc: linux-kernel@...r.kernel.org, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Jisheng Zhang <jszhang@...nel.org>, linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
kernel@...labora.com
Subject: Re: [PATCH v4 1/1] dt-bindings: mmc: Add support for rk3576 eMMC
On Wed, 4 Sept 2024 at 22:32, Detlev Casanova
<detlev.casanova@...labora.com> wrote:
>
> The device is compatible with rk3588, so add an entry for the 2
> compatibles together.
>
> The rk3576 device has a power-domain that needs to be on for the eMMC to
> be used. Add it as a requirement.
>
> Signed-off-by: Detlev Casanova <detlev.casanova@...labora.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> .../bindings/mmc/snps,dwcmshc-sdhci.yaml | 37 +++++++++++++++----
> 1 file changed, 29 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> index 80d50178d2e3..c3d5e0230af1 100644
> --- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> @@ -12,14 +12,18 @@ maintainers:
>
> properties:
> compatible:
> - enum:
> - - rockchip,rk3568-dwcmshc
> - - rockchip,rk3588-dwcmshc
> - - snps,dwcmshc-sdhci
> - - sophgo,cv1800b-dwcmshc
> - - sophgo,sg2002-dwcmshc
> - - sophgo,sg2042-dwcmshc
> - - thead,th1520-dwcmshc
> + oneOf:
> + - items:
> + - const: rockchip,rk3576-dwcmshc
> + - const: rockchip,rk3588-dwcmshc
> + - enum:
> + - rockchip,rk3568-dwcmshc
> + - rockchip,rk3588-dwcmshc
> + - snps,dwcmshc-sdhci
> + - sophgo,cv1800b-dwcmshc
> + - sophgo,sg2002-dwcmshc
> + - sophgo,sg2042-dwcmshc
> + - thead,th1520-dwcmshc
>
> reg:
> maxItems: 1
> @@ -35,6 +39,9 @@ properties:
> minItems: 1
> maxItems: 5
>
> + power-domains:
> + maxItems: 1
> +
> resets:
> maxItems: 5
>
> @@ -97,6 +104,20 @@ allOf:
> - const: block
> - const: timer
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: rockchip,rk3576-dwcmshc
> +
> + then:
> + required:
> + - power-domains
> +
> + else:
> + properties:
> + power-domains: false
> +
> unevaluatedProperties: false
>
> examples:
> --
> 2.46.0
>
Powered by blists - more mailing lists