linux-kernel - Re: [brauner-vfs:work.f_version.wip.v1] [proc] e85c0d9e72: WARNING:lock_held_when_returning_to_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZtkSVZ47t9+KjHGK@xsang-OptiPlex-9020>
Date: Thu, 5 Sep 2024 10:07:17 +0800
From: Oliver Sang <oliver.sang@...el.com>
To: Christian Brauner <brauner@...nel.org>
CC: <oe-lkp@...ts.linux.dev>, <lkp@...el.com>, Christian Brauner
	<christianvanbrauner@...il.com>, <linux-kernel@...r.kernel.org>,
	<linux-fsdevel@...r.kernel.org>, <oliver.sang@...el.com>
Subject: Re: [brauner-vfs:work.f_version.wip.v1] [proc] e85c0d9e72:
 WARNING:lock_held_when_returning_to_user_space

hi, Christian Brauner,

On Tue, Sep 03, 2024 at 03:59:19PM +0200, Christian Brauner wrote:
> On Tue, Sep 03, 2024 at 09:53:05PM GMT, kernel test robot wrote:
> > 
> > 
> > Hello,
> > 
> > kernel test robot noticed "WARNING:lock_held_when_returning_to_user_space" on:
> > 
> > commit: e85c0d9e725529a5ed68ad0b6abc62b332654156 ("proc: wean of off f_version")
> > https://git.kernel.org/cgit/linux/kernel/git/vfs/vfs.git work.f_version.wip.v1
> 
> This is once again an old branch that's dead and was never sent.
> Can you please exclude anything that has a *.v<nr> suffix? I thought I
> already added a commit to this effect to the repository.

got it. seems previous deny pattern has a small problem.

Philip just pushed a fix [1]

at the same time, we noticed for v<nr>, there are two different styles in 3
repos owned by your that we are monitoring.
style #1: _v<nr>
style #2: .v<nr>

should we deny both or handle them differently for different repo?

repo #1:

$ git remote -v
origin  https://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git (fetch)
origin  https://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git (push)

$ git branch | grep _v
  2018-11-02/namespace_br_netfilter_sysctls_v0
  2019-01-12/proc_overflow_v4
  binderfs_new_mount_api_v1
...

$ git branch | grep -E "\.v"
  cgroup.kill.v1
  cgroup.kill.v2
  cgroup.kill.v3
...

repo #2:

$ git remote -v
origin  https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git (fetch)
origin  https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git (push)

$ git branch | grep _v  (there is no _v<nr> in results)
  work.f_version
  work.f_version.wip.v1

$ git branch | grep -E "\.v"
  b4/fs-btrfs-mount-api.v1
  b4/fs-btrfs-mount-api.wip.v1
  b4/fs-move-mount-beneath.v4
...

repo #3:

$ git remote -v
origin  https://git.kernel.org/pub/scm/linux/kernel/git/vfs/idmapping.git (fetch)
origin  https://git.kernel.org/pub/scm/linux/kernel/git/vfs/idmapping.git (push)

$ git branch | grep _v
<-- noting

$ git branch | grep -E "\.v"
  b4/fs-acl-remove-generic-xattr-handlers.v3.wip.v2
  b4/fs-fuse-acl.wip.v2
  b4/fs-idmapped-mnt_idmap-conversion.v1



[1]
https://github.com/intel/lkp-tests/commit/06ab3e9c88486633c0fbf87748e302783df50f04

the change is similar to below

--- a/repo/linux/brauner-vfs
+++ b/repo/linux/brauner-vfs
@@ -1,7 +1,7 @@
 url: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
 integration_testing_branches: vfs.all
 owner: Christian Brauner <brauner@...nel.org>
-branch_denylist: .*_v[0-9]*|.*wip*
+branch_denylist: .*_v[0-9]*|.*wip.*