linux-kernel - Re: [RFC PATCH 00/12] media: ov5645: Add support for streams

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1eead6a9-87c7-409d-abd6-32c4d0dafe05@ideasonboard.com>
Date: Thu, 5 Sep 2024 13:57:36 +0300
From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Kieran Bingham <kieran.bingham@...asonboard.com>,
 Jacopo Mondi <jacopo.mondi@...asonboard.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, linux-media@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
 Biju Das <biju.das.jz@...renesas.com>,
 Fabrizio Castro <fabrizio.castro.jz@...esas.com>,
 Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [RFC PATCH 00/12] media: ov5645: Add support for streams

On 05/09/2024 13:51, Lad, Prabhakar wrote:
> Hi Tomi,
> 
> On Thu, Sep 5, 2024 at 11:29 AM Tomi Valkeinen
> <tomi.valkeinen@...asonboard.com> wrote:
>>
>> On 05/09/2024 13:27, Lad, Prabhakar wrote:
>>> Hi Tomi,
>>>
>>> On Thu, Sep 5, 2024 at 10:11 AM Tomi Valkeinen
>>> <tomi.valkeinen@...asonboard.com> wrote:
>>>>
>>> <snip>
>>>>> I think you actually want 1/0->0/0 routing. The error says that the sink
>>>>> side device has routing which does not have a stream at stream ID 1, or
>>>>> no routing support at all, which implies a single stream at stream ID 0.
>>>>
>>>> Looking at patch 12, there's something wrong with the approach here. Are
>>>> you perhaps trying to define the CSI-2 VC with the streams?
>>>>
>>> Yes, based on the previous feedback received, I am implementing
>>> virtual channels as streams. If this isn't the correct approach can
>>> you please guide me on what we should be using to support virtual
>>> channels?
>>
>> Can you describe what kind of hardware you have and how the VCs are
>> supposed to be configured and used there?
>>
> 
>   __________________                       ______________
>      _____________________
> |                                     |                     |
>                  |                   |
>        |
> | OV5645   Sensor        |                     |  RZ/G2L CSI2   |
>               |  RZ/G2L CRU                 |
> | 1ch out of 4x VC         |---------------> |   4x VC
> |-------------->|  1Ch capture out 4xVC  |
> |__________________|                      |_____________|
>       |____________________|

The formatting there is quite broken, but afaiu you have a standard 
setup with single stream. Then it should be as I wrote earlier: a single 
hardcoded 1/0->0/0 route in the sensor, and .get_frame_desc() returns VC 
0 and a suitable DT for that stream.

When you say "implementing virtual channels as streams", what is the 
feature/requirement you are looking at? Do you have some specific need 
to use other VCs than 0?

  Tomi