linux-kernel - Re: [PATCH] clk: qcom: clk-alpha-pll: Replace divide operator with comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29874390-2c8b-400a-9034-cccb929346a2@quicinc.com>
Date: Thu, 5 Sep 2024 16:28:20 +0530
From: Satya Priya Kakitapalli <quic_skakitap@...cinc.com>
To: Jon Hunter <jonathanh@...dia.com>,
        Vladimir Zapolskiy
	<vladimir.zapolskiy@...aro.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>
CC: <linux-arm-msm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Ajit Pandey <quic_ajipan@...cinc.com>,
        "Imran
 Shaik" <quic_imrashai@...cinc.com>,
        Taniya Das <quic_tdas@...cinc.com>,
        Jagadeesh Kona <quic_jkona@...cinc.com>,
        kernel test robot <lkp@...el.com>,
        Dan Carpenter <dan.carpenter@...aro.org>,
        "linux-tegra@...r.kernel.org"
	<linux-tegra@...r.kernel.org>
Subject: Re: [PATCH] clk: qcom: clk-alpha-pll: Replace divide operator with
 comparison

Hi Jon,


>>>>
>>>> remainder = do_div(rate, prate);
>>>>
>>>>> -    if ((remainder * 2) / prate)
>>>>> +    if ((remainder * 2) >= prate)
>>>>>           *l = *l + 1;
>>>>
>>>> *l = rate + (u32)(remainder * 2 >= prate);
>>>
>>>
>>> The above change does fix this build error for me.
>>>
>>> Satya, did you intend this to be a fix? Can we get this into -next?
>>>
>>
>> Yes, I have posted a v2 for this last week, but there are few open 
>> comments on that, I'll address them and post V3 including the build 
>> error you reported in commit-text.
>>
>>
>> [v2] 
>> https://lore.kernel.org/linux-clk/20240814102005.33493-1-quic_skakitap@quicinc.com/
>
>
> Have you push a V3 yet?


Not yet Jon, I had a query regarding Bjorn's comment where he mentioned 
the patch wouldn't compile on arm32 target, I am trying to check that 
with him. Once I get the details I'll make the changes accordingly and 
post V3.


Thanks,

Satya priya