linux-kernel - Re: [PATCH -v2] Resource: fix region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <65838cc0-9a20-4994-a0ef-9cd50bb00951@redhat.com>
Date: Thu, 5 Sep 2024 13:08:35 +0200
From: David Hildenbrand <david@...hat.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Dan Williams <dan.j.williams@...el.com>
Cc: "Huang, Ying" <ying.huang@...el.com>,
 Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, linux-cxl@...r.kernel.org,
 Davidlohr Bueso <dave@...olabs.net>,
 Jonathan Cameron <jonathan.cameron@...wei.com>,
 Dave Jiang <dave.jiang@...el.com>,
 Alison Schofield <alison.schofield@...el.com>,
 Vishal Verma <vishal.l.verma@...el.com>, Ira Weiny <ira.weiny@...el.com>,
 Alistair Popple <apopple@...dia.com>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Baoquan He <bhe@...hat.com>
Subject: Re: [PATCH -v2] Resource: fix region_intersects() for CXL memory

On 05.09.24 12:56, Andy Shevchenko wrote:
> On Wed, Sep 04, 2024 at 04:58:20PM -0700, Dan Williams wrote:
>> Huang, Ying wrote:
>>> Andy Shevchenko <andriy.shevchenko@...ux.intel.com> writes:
> 
> [..]
> 
>>>> You may move Cc list after '---', so it won't unnecessarily pollute the commit
>>>> message.
>>>
>>> Emm... It appears that it's a common practice to include "Cc" in the
>>> commit log.
>>
>> Yes, just ignore this feedback, it goes against common practice. Cc list
>> as is looks sane to me.
> 
> It seems nobody can give technical arguments why it's better than just keeping
> them outside of the commit message. Mantra "common practice" nowadays is
> questionable.

Just look at how patches look like in the git tree that Andrew picks up. 
(IIRC, he adds a bunch of CCs himself that are not even part of the 
original patch).

Having in the git tree who was actually involved/CCed can be quite 
valuable. More helpful than get_maintainers.pl sometimes.

-- 
Cheers,

David / dhildenb