linux-kernel - Re: [PATCH 06/19] dt-bindings: power: rpmpd: Add QCS8300 power domains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8ad6d902-8d19-49a5-b12d-d0d8b0b17cb6@kernel.org>
Date: Thu, 5 Sep 2024 13:31:56 +0200
From: Konrad Dybcio <konradybcio@...nel.org>
To: Konrad Dybcio <konradybcio@...nel.org>,
 Jingyi Wang <quic_jingyw@...cinc.com>, Bjorn Andersson
 <andersson@...nel.org>, Mathieu Poirier <mathieu.poirier@...aro.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
 Vinod Koul <vkoul@...nel.org>, Kishon Vijay Abraham I <kishon@...nel.org>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 Alim Akhtar <alim.akhtar@...sung.com>, Avri Altman <avri.altman@....com>,
 Bart Van Assche <bvanassche@....org>, Andy Gross <agross@...nel.org>,
 Ulf Hansson <ulf.hansson@...aro.org>, Thomas Gleixner <tglx@...utronix.de>,
 Will Deacon <will@...nel.org>, Robin Murphy <robin.murphy@....com>,
 Joerg Roedel <joro@...tes.org>, Robert Marko <robimarko@...il.com>,
 Das Srinagesh <quic_gurus@...cinc.com>, Jassi Brar
 <jassisinghbrar@...il.com>, Lee Jones <lee@...nel.org>,
 Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
 Catalin Marinas <catalin.marinas@....com>
Cc: linux-arm-msm@...r.kernel.org, linux-remoteproc@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-phy@...ts.infradead.org, linux-scsi@...r.kernel.org,
 linux-pm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 iommu@...ts.linux.dev, Shazad Hussain <quic_shazhuss@...cinc.com>,
 Tingguo Cheng <quic_tingguoc@...cinc.com>
Subject: Re: [PATCH 06/19] dt-bindings: power: rpmpd: Add QCS8300 power
 domains

On 5.09.2024 1:30 PM, Konrad Dybcio wrote:
> On 4.09.2024 10:33 AM, Jingyi Wang wrote:
>> From: Shazad Hussain <quic_shazhuss@...cinc.com>
>>
>> Add compatible and constants for the power domains exposed by the RPMH
>> in the Qualcomm QCS8300 platform.
>>
>> Signed-off-by: Shazad Hussain <quic_shazhuss@...cinc.com>
>> Signed-off-by: Tingguo Cheng <quic_tingguoc@...cinc.com>
>> Signed-off-by: Jingyi Wang <quic_jingyw@...cinc.com>
>> ---
>>  .../devicetree/bindings/power/qcom,rpmpd.yaml         |  1 +
>>  include/dt-bindings/power/qcom-rpmpd.h                | 19 +++++++++++++++++++
>>  2 files changed, 20 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
>> index 929b7ef9c1bc..be1a9cb71a9b 100644
>> --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
>> +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
>> @@ -32,6 +32,7 @@ properties:
>>            - qcom,msm8998-rpmpd
>>            - qcom,qcm2290-rpmpd
>>            - qcom,qcs404-rpmpd
>> +          - qcom,qcs8300-rpmhpd
>>            - qcom,qdu1000-rpmhpd
>>            - qcom,qm215-rpmpd
>>            - qcom,sa8155p-rpmhpd
>> diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h
>> index 608087fb9a3d..7dd7b9ebc480 100644
>> --- a/include/dt-bindings/power/qcom-rpmpd.h
>> +++ b/include/dt-bindings/power/qcom-rpmpd.h
>> @@ -4,6 +4,25 @@
>>  #ifndef _DT_BINDINGS_POWER_QCOM_RPMPD_H
>>  #define _DT_BINDINGS_POWER_QCOM_RPMPD_H
>>  
>> +/* QCS8300 Power Domain Indexes */
>> +#define QCS8300_CX	0
>> +#define QCS8300_CX_AO	1
>> +#define QCS8300_DDR	2
>> +#define QCS8300_EBI	3
>> +#define QCS8300_GFX	4
>> +#define QCS8300_LCX	5
>> +#define QCS8300_LMX	6
>> +#define QCS8300_MMCX	7
>> +#define QCS8300_MMCX_AO	8
>> +#define QCS8300_MSS	9
>> +#define QCS8300_MX	10
>> +#define QCS8300_MX_AO	11
>> +#define QCS8300_MXC	12
>> +#define QCS8300_MXC_AO	13
>> +#define QCS8300_NSP0	14
>> +#define QCS8300_NSP1	15
>> +#define QCS8300_XO	16
> 
> Some time ago we moved RPM*h*pd to common defines.. we should
> definitely do the same here. Please reuse the RPMPD_xxx definitions
> from [1] and credit Rohit in the commit message, as he did some
> processing on that to make sure they're ordered based on usage

Oh no, this is actually rpmhpd... drop this patch and use RPMHPD_x
from include/dt-bindings/power/qcom,rpmhpd.h

Konrad