linux-kernel - Re: [PATCH v1 1/5] gpio: stmpe: Fix IRQ related error messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbskty+v0V90MrP5nm=S-mqHQq1B5C07QciaYJr09-88g@mail.gmail.com>
Date: Thu, 5 Sep 2024 13:33:56 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-gpio@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	Bartosz Golaszewski <brgl@...ev.pl>, Maxime Coquelin <mcoquelin.stm32@...il.com>, 
	Alexandre Torgue <alexandre.torgue@...s.st.com>
Subject: Re: [PATCH v1 1/5] gpio: stmpe: Fix IRQ related error messages

On Mon, Sep 2, 2024 at 3:32 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:

> First of all, remove duplicate message that platform_get_irq()
> does already print. Second, correct the error message when unable
> to register a handler, which is broken in two ways:
> 1) the misleading 'get' vs. 'register';
> 2) missing '\n' at the end.
>
> (Yes, for the curious ones, the dev_*() cases do not require '\n'
> and issue it automatically, but it's better to have them explicit)
>
> Fix all this here.
>
> Fixes: 1882e769362b ("gpio: stmpe: Simplify with dev_err_probe()")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij