linux-kernel - Re: [PATCH] arm64: dts: rockchip: Add a few aliases to the PineTab2 dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D3YCHAOLOU6W.3B8MJYAYWOEGK@cknow.org>
Date: Thu, 05 Sep 2024 14:21:12 +0200
From: "Diederik de Haas" <didi.debian@...ow.org>
To: "Krzysztof Kozlowski" <krzk@...nel.org>, "Dragan Simic"
 <dsimic@...jaro.org>, <linux-rockchip@...ts.infradead.org>
Cc: <heiko@...ech.de>, <linux-arm-kernel@...ts.infradead.org>,
 <devicetree@...r.kernel.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
 <conor+dt@...nel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: rockchip: Add a few aliases to the PineTab2
 dtsi

On Thu Sep 5, 2024 at 1:39 PM CEST, Krzysztof Kozlowski wrote:
> On 05/09/2024 13:32, Dragan Simic wrote:
> > Sprinkle a few commonly used aliases onto the PineTab2 dtsi file, to improve
> > its readability a bit, to make it easier to refer to the actual nodes later,
> > if needed, and to add a bit more detail to some of the labels.
> > 
> > Suggested-by: Diederik de Haas <didi.debian@...ow.org>
> > Signed-off-by: Dragan Simic <dsimic@...jaro.org>
>
> Unused aliases do not improve readability, so for me this change is
> making code worse without valid reason.

This came forth by a question from me to Dragan about a patch for
another board which doesn't have a charger defined at all (yet).
I actually have that patch (but not the HW) for a while (~1.5 year)
now and I had used `rk817_charger: charger` for that, probably because
I saw that being used everywhere else.

Then I compared it to the PineTab2 and noticed it had only `charger`, so
I asked "What should I use? With or without the alias?"
In this case the inconsistency is causing confusion (with me).

So: What should be used for that other/new board(s)?

Cheers,
  Diederik

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)