linux-kernel - Re: [PATCH v3 12/14] mm: multi-gen LRU: walk_pte_range() use pte_offset_map_rw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <6867F624-A83C-4A3C-947D-ECFA4925130F@linux.dev>
Date: Thu, 5 Sep 2024 20:23:05 +0800
From: Muchun Song <muchun.song@...ux.dev>
To: Qi Zheng <zhengqi.arch@...edance.com>
Cc: David Hildenbrand <david@...hat.com>,
 Hugh Dickins <hughd@...gle.com>,
 Matthew Wilcox <willy@...radead.org>,
 "Vlastimil Babka (SUSE)" <vbabka@...nel.org>,
 akpm@...ux-foundation.org,
 rppt@...nel.org,
 vishal.moola@...il.com,
 peterx@...hat.com,
 ryan.roberts@....com,
 christophe.leroy2@...soprasteria.com,
 linux-kernel@...r.kernel.org,
 linux-mm@...ck.org,
 linux-arm-kernel@...ts.infradead.org,
 linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v3 12/14] mm: multi-gen LRU: walk_pte_range() use
 pte_offset_map_rw_nolock()



> On Sep 4, 2024, at 16:40, Qi Zheng <zhengqi.arch@...edance.com> wrote:
> 
> In walk_pte_range(), we may modify the pte entry after holding the ptl, so
> convert it to using pte_offset_map_rw_nolock(). At this time, the
> pte_same() check is not performed after the ptl held, so we should get
> pmdval and do pmd_same() check to ensure the stability of pmd entry.
> 
> Signed-off-by: Qi Zheng <zhengqi.arch@...edance.com>

Reviewed-by: Muchun Song <muchun.song@...ux.dev>

Thanks.