linux-kernel - Re: [PATCH v1] ceph: Fix typo in the comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4730b8a2-7328-4a36-865c-be8ae1e064b2@redhat.com>
Date: Thu, 5 Sep 2024 20:26:57 +0800
From: Xiubo Li <xiubli@...hat.com>
To: Yan Zhen <yanzhen@...o.com>, idryomov@...il.com
Cc: linux-kernel@...r.kernel.org, opensource.kernel@...o.com
Subject: Re: [PATCH v1] ceph: Fix typo in the comment

Hi Yan Zhen,

Thanks for your patch.

Next time please to or cc ceph-devel@...r.kernel.org list, or the mails 
could be missed.

On 9/5/24 19:32, Yan Zhen wrote:
> Correctly spelled comments make it easier for the reader to understand
> the code.
>
> replace 'tagert' with 'target' in the comment &
> replace 'vaild' with 'valid' in the comment &
> replace 'carefull' with 'careful' in the comment &
> replace 'trsaverse' with 'traverse' in the comment.
>
> Signed-off-by: Yan Zhen <yanzhen@...o.com>
> ---
>   fs/ceph/caps.c       | 2 +-
>   fs/ceph/dir.c        | 2 +-
>   fs/ceph/inode.c      | 2 +-
>   fs/ceph/mds_client.c | 2 +-
>   4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c
> index 6561a6cd9..4aaaa26de 100644
> --- a/fs/ceph/caps.c
> +++ b/fs/ceph/caps.c
> @@ -4150,7 +4150,7 @@ static void handle_cap_export(struct inode *inode, struct ceph_mds_caps *ex,
>   		ceph_remove_cap(mdsc, cap, false);
>   		goto out_unlock;
>   	} else if (tsession) {
> -		/* add placeholder for the export tagert */
> +		/* add placeholder for the export target */
>   		int flag = (cap == ci->i_auth_cap) ? CEPH_CAP_FLAG_AUTH : 0;
>   		tcap = new_cap;
>   		ceph_add_cap(inode, tsession, t_cap_id, issued, 0,
> diff --git a/fs/ceph/dir.c b/fs/ceph/dir.c
> index 18c72b305..e23f8a40f 100644
> --- a/fs/ceph/dir.c
> +++ b/fs/ceph/dir.c
> @@ -2059,7 +2059,7 @@ static int ceph_d_delete(const struct dentry *dentry)
>   		return 0;
>   	if (ceph_snap(d_inode(dentry)) != CEPH_NOSNAP)
>   		return 0;
> -	/* vaild lease? */
> +	/* valid lease? */
>   	di = ceph_dentry(dentry);
>   	if (di) {
>   		if (__dentry_lease_is_valid(di))
> diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c
> index 4a8eec462..315ef02f9 100644
> --- a/fs/ceph/inode.c
> +++ b/fs/ceph/inode.c
> @@ -1779,7 +1779,7 @@ int ceph_fill_trace(struct super_block *sb, struct ceph_mds_request *req)
>   		if (err < 0)
>   			goto done;
>   	} else if (rinfo->head->is_dentry && req->r_dentry) {
> -		/* parent inode is not locked, be carefull */
> +		/* parent inode is not locked, be careful */
>   		struct ceph_vino *ptvino = NULL;
>   		dvino.ino = le64_to_cpu(rinfo->diri.in->ino);
>   		dvino.snap = le64_to_cpu(rinfo->diri.in->snapid);
> diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
> index 276e34ab3..1a1e71f20 100644
> --- a/fs/ceph/mds_client.c
> +++ b/fs/ceph/mds_client.c
> @@ -4910,7 +4910,7 @@ static void send_mds_reconnect(struct ceph_mds_client *mdsc,
>   	} else {
>   		recon_state.msg_version = 2;
>   	}
> -	/* trsaverse this session's caps */
> +	/* traverse this session's caps */
>   	err = ceph_iterate_session_caps(session, reconnect_caps_cb, &recon_state);
>   
>   	spin_lock(&session->s_cap_lock);

LGTM.

Reviewed-by: Xiubo Li <xiubli@...hat.com>