lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e868a812-def6-483b-95a1-ffc8e47d0577@kernel.org>
Date: Thu, 5 Sep 2024 14:39:52 +0200
From: Konrad Dybcio <konradybcio@...nel.org>
To: Konrad Dybcio <konradybcio@...nel.org>,
 Fabien Parent <fabien.parent@...aro.org>,
 Bjorn Andersson <andersson@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Luca Weiss <luca@...aweiss.eu>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: msm8939: revert use of APCS mbox for
 RPM

On 5.09.2024 2:38 PM, Konrad Dybcio wrote:
> On 4.09.2024 8:26 PM, Fabien Parent wrote:
>> Commit 22e4e43484c4 ("arm64: dts: qcom: msm8939: Use mboxes
>> properties for APCS") broke the boot on msm8939 platforms.
>>
>> The issue comes from the SMD driver failing to request the mbox
>> channel because of circular dependencies:
>> 	1. rpm -> apcs1_mbox -> rpmcc (RPM_SMD_XO_CLK_SRC) -> rpm.
>> 	2. rpm -> apcs1_mbox -> gcc -> rpmcc (RPM_SMD_XO_CLK_SRC) -> rpm
>> 	3. rpm -> apcs1_mbox -> apcs2 -> gcc -> rpmcc (RPM_SMD_XO_CLK_SRC) -> rpm
>>
>> To fix this issue let's switch back to using the deprecated
>> qcom,ipc property for the RPM node.
>>
>> Fixes: 22e4e43484c4 ("arm64: dts: qcom: msm8939: Use mboxes properties for APCS")
>> Signed-off-by: Fabien Parent <fabien.parent@...aro.org>
>> ---
> 
> This is fine as a stopgap solution, Bjorn can we push it in -fixes?
> 
> This platform is admittedly not of top importance.. but fixing this
> eventually would be nice
> 
> #regzbot introduced: 22e4e43484c4

Reviewed-by: Konrad Dybcio <konradybcio@...nel.org>

Konrad

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ