linux-kernel - Re: [PATCH 3/3] arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f5bcc6c-5ee0-4fef-bb58-f7acf9551fc1@lunn.ch>
Date: Thu, 5 Sep 2024 14:53:42 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Junhao Xie <bigfoot@...ssfun.cn>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Heiko Stuebner <heiko@...ech.de>, Jonas Karlman <jonas@...boo.se>,
	Chukun Pan <amadeus@....edu.cn>, FUKAUMI Naoki <naoki@...xa.com>,
	Dragan Simic <dsimic@...jaro.org>,
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: rockchip: add dts for Ariaboard
 Photonicat RK3568

On Thu, Sep 05, 2024 at 07:17:03PM +0800, Junhao Xie wrote:
> On 2024/9/5 01:25, Andrew Lunn wrote:
> >> +&gmac1 {
> [...]
> > This has been discussed a few times. You should be using phy-mode
> > rgmii-id.
> 
> After I changed phy-mode to rgmii-id, it seemed to work,
> but it didn't transmit any data.
> Maybe I made a mistake or should I continue to use phy-mode rgmii?

How did you change the rx_delay and tx_delay?

In general, we want the PHY to add the delay, not the MAC. Most boards
in Linux do that. But boards using the motocomm PHY have got into a
cargo cult copy/paste of using the MAC to add the delays.

	Andrew