lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <bdc0312b-6243-4dbd-acf9-9c1499db3e03@linux.intel.com> Date: Fri, 6 Sep 2024 10:10:01 -0400 From: "Liang, Kan" <kan.liang@...ux.intel.com> To: Namhyung Kim <namhyung@...nel.org>, Arnaldo Carvalho de Melo <acme@...nel.org>, Ian Rogers <irogers@...gle.com> Cc: Jiri Olsa <jolsa@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>, Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...nel.org>, LKML <linux-kernel@...r.kernel.org>, linux-perf-users@...r.kernel.org, Ravi Bangoria <ravi.bangoria@....com>, Mark Rutland <mark.rutland@....com>, James Clark <james.clark@....com>, Kajol Jain <kjain@...ux.ibm.com>, Thomas Richter <tmricht@...ux.ibm.com>, Atish Patra <atishp@...shpatra.org>, Palmer Dabbelt <palmer@...osinc.com>, Mingwei Zhang <mizhang@...gle.com>, James Clark <james.clark@...aro.org> Subject: Re: [PATCH 02/10] perf tools: Don't set attr.exclude_guest by default On 2024-09-05 4:24 p.m., Namhyung Kim wrote: > The exclude_guest in the event attribute is to limit profiling in the > host environment. But I'm not sure why we want to set it by default > cause we don't care about it in most cases and I feel like it just > makes new PMU implementation complicated. > > Of course it's useful for perf kvm command so I added the > exclude_GH_default variable to preserve the old behavior for perf kvm > and other commands like perf record and stat won't set the exclude bit. > This is helpful for AMD IBS case since having exclude_guest bit will > clear new feature bit due to the missing feature check logic. > > $ sysctl kernel.perf_event_paranoid > kernel.perf_event_paranoid = 0 > > $ perf record -W -e ibs_op// -vv true 2>&1 | grep switching > switching off PERF_FORMAT_LOST support > switching off weight struct support > switching off bpf_event > switching off ksymbol > switching off cloexec flag > switching off mmap2 > switching off exclude_guest, exclude_host > > Intestingly, I found it sets the exclude_bit if "u" modifier is used. > I don't know why but it's neither intuitive nor consistent. Let's > remove the bit there too. > > Cc: Mark Rutland <mark.rutland@....com> > Cc: James Clark <james.clark@...aro.org> > Cc: Ravi Bangoria <ravi.bangoria@....com> > Signed-off-by: Namhyung Kim <namhyung@...nel.org> > --- > tools/perf/builtin-kvm.c | 1 + > tools/perf/tests/attr/test-record-dummy-C0 | 2 +- > tools/perf/tests/parse-events.c | 18 +++++++++--------- > tools/perf/util/parse-events.c | 2 +- > tools/perf/util/util.c | 10 ++++++++-- > tools/perf/util/util.h | 3 +++ > 6 files changed, 23 insertions(+), 13 deletions(-) > > diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c > index 55ea17c5ff02acf7..5e32d4e78fdf2424 100644 > --- a/tools/perf/builtin-kvm.c > +++ b/tools/perf/builtin-kvm.c > @@ -2147,6 +2147,7 @@ int cmd_kvm(int argc, const char **argv) > "buildid-list", "stat", NULL }; > const char *kvm_usage[] = { NULL, NULL }; > > + exclude_HG_default = true; exclude_GH_default? Thanks, Kan > perf_host = 0; > perf_guest = 1; > > diff --git a/tools/perf/tests/attr/test-record-dummy-C0 b/tools/perf/tests/attr/test-record-dummy-C0 > index 576ec48b3aafaa6a..8ce6f0a5df5b7013 100644 > --- a/tools/perf/tests/attr/test-record-dummy-C0 > +++ b/tools/perf/tests/attr/test-record-dummy-C0 > @@ -37,7 +37,7 @@ precise_ip=0 > mmap_data=0 > sample_id_all=1 > exclude_host=0 > -exclude_guest=1 > +exclude_guest=0 > exclude_callchain_kernel=0 > exclude_callchain_user=0 > mmap2=1 > diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-events.c > index 639e65a9bf61801a..9077d581c0d05e62 100644 > --- a/tools/perf/tests/parse-events.c > +++ b/tools/perf/tests/parse-events.c > @@ -933,7 +933,7 @@ static int test__group2(struct evlist *evlist) > TEST_ASSERT_VAL("wrong exclude_user", !evsel->core.attr.exclude_user); > TEST_ASSERT_VAL("wrong exclude_kernel", !evsel->core.attr.exclude_kernel); > TEST_ASSERT_VAL("wrong exclude_hv", evsel->core.attr.exclude_hv); > - TEST_ASSERT_VAL("wrong exclude guest", evsel->core.attr.exclude_guest); > + TEST_ASSERT_VAL("wrong exclude guest", !evsel->core.attr.exclude_guest); > TEST_ASSERT_VAL("wrong exclude host", !evsel->core.attr.exclude_host); > TEST_ASSERT_VAL("wrong precise_ip", !evsel->core.attr.precise_ip); > TEST_ASSERT_VAL("wrong leader", evsel__is_group_leader(evsel)); > @@ -948,7 +948,7 @@ static int test__group2(struct evlist *evlist) > TEST_ASSERT_VAL("wrong exclude_user", !evsel->core.attr.exclude_user); > TEST_ASSERT_VAL("wrong exclude_kernel", evsel->core.attr.exclude_kernel); > TEST_ASSERT_VAL("wrong exclude_hv", evsel->core.attr.exclude_hv); > - TEST_ASSERT_VAL("wrong exclude guest", evsel->core.attr.exclude_guest); > + TEST_ASSERT_VAL("wrong exclude guest", !evsel->core.attr.exclude_guest); > TEST_ASSERT_VAL("wrong exclude host", !evsel->core.attr.exclude_host); > TEST_ASSERT_VAL("wrong precise_ip", !evsel->core.attr.precise_ip); > if (evsel__has_leader(evsel, leader)) > @@ -1073,7 +1073,7 @@ static int test__group3(struct evlist *evlist __maybe_unused) > TEST_ASSERT_VAL("wrong exclude_user", !evsel->core.attr.exclude_user); > TEST_ASSERT_VAL("wrong exclude_kernel", evsel->core.attr.exclude_kernel); > TEST_ASSERT_VAL("wrong exclude_hv", evsel->core.attr.exclude_hv); > - TEST_ASSERT_VAL("wrong exclude guest", evsel->core.attr.exclude_guest); > + TEST_ASSERT_VAL("wrong exclude guest", !evsel->core.attr.exclude_guest); > TEST_ASSERT_VAL("wrong exclude host", !evsel->core.attr.exclude_host); > TEST_ASSERT_VAL("wrong precise_ip", !evsel->core.attr.precise_ip); > TEST_ASSERT_VAL("wrong leader", evsel__is_group_leader(evsel)); > @@ -1223,7 +1223,7 @@ static int test__group5(struct evlist *evlist __maybe_unused) > TEST_ASSERT_VAL("wrong exclude_user", !evsel->core.attr.exclude_user); > TEST_ASSERT_VAL("wrong exclude_kernel", !evsel->core.attr.exclude_kernel); > TEST_ASSERT_VAL("wrong exclude_hv", !evsel->core.attr.exclude_hv); > - TEST_ASSERT_VAL("wrong exclude guest", evsel->core.attr.exclude_guest); > + TEST_ASSERT_VAL("wrong exclude guest", !evsel->core.attr.exclude_guest); > TEST_ASSERT_VAL("wrong exclude host", !evsel->core.attr.exclude_host); > TEST_ASSERT_VAL("wrong precise_ip", !evsel->core.attr.precise_ip); > TEST_ASSERT_VAL("wrong leader", evsel__is_group_leader(evsel)); > @@ -1438,7 +1438,7 @@ static int test__leader_sample1(struct evlist *evlist) > TEST_ASSERT_VAL("wrong exclude_user", !evsel->core.attr.exclude_user); > TEST_ASSERT_VAL("wrong exclude_kernel", !evsel->core.attr.exclude_kernel); > TEST_ASSERT_VAL("wrong exclude_hv", !evsel->core.attr.exclude_hv); > - TEST_ASSERT_VAL("wrong exclude guest", evsel->core.attr.exclude_guest); > + TEST_ASSERT_VAL("wrong exclude guest", !evsel->core.attr.exclude_guest); > TEST_ASSERT_VAL("wrong exclude host", !evsel->core.attr.exclude_host); > TEST_ASSERT_VAL("wrong precise_ip", !evsel->core.attr.precise_ip); > TEST_ASSERT_VAL("wrong group name", !evsel->group_name); > @@ -1454,7 +1454,7 @@ static int test__leader_sample1(struct evlist *evlist) > TEST_ASSERT_VAL("wrong exclude_user", !evsel->core.attr.exclude_user); > TEST_ASSERT_VAL("wrong exclude_kernel", !evsel->core.attr.exclude_kernel); > TEST_ASSERT_VAL("wrong exclude_hv", !evsel->core.attr.exclude_hv); > - TEST_ASSERT_VAL("wrong exclude guest", evsel->core.attr.exclude_guest); > + TEST_ASSERT_VAL("wrong exclude guest", !evsel->core.attr.exclude_guest); > TEST_ASSERT_VAL("wrong exclude host", !evsel->core.attr.exclude_host); > TEST_ASSERT_VAL("wrong precise_ip", !evsel->core.attr.precise_ip); > TEST_ASSERT_VAL("wrong leader", evsel__has_leader(evsel, leader)); > @@ -1469,7 +1469,7 @@ static int test__leader_sample1(struct evlist *evlist) > TEST_ASSERT_VAL("wrong exclude_user", !evsel->core.attr.exclude_user); > TEST_ASSERT_VAL("wrong exclude_kernel", !evsel->core.attr.exclude_kernel); > TEST_ASSERT_VAL("wrong exclude_hv", !evsel->core.attr.exclude_hv); > - TEST_ASSERT_VAL("wrong exclude guest", evsel->core.attr.exclude_guest); > + TEST_ASSERT_VAL("wrong exclude guest", !evsel->core.attr.exclude_guest); > TEST_ASSERT_VAL("wrong exclude host", !evsel->core.attr.exclude_host); > TEST_ASSERT_VAL("wrong precise_ip", !evsel->core.attr.precise_ip); > TEST_ASSERT_VAL("wrong group name", !evsel->group_name); > @@ -1498,7 +1498,7 @@ static int test__leader_sample2(struct evlist *evlist __maybe_unused) > TEST_ASSERT_VAL("wrong exclude_user", !evsel->core.attr.exclude_user); > TEST_ASSERT_VAL("wrong exclude_kernel", evsel->core.attr.exclude_kernel); > TEST_ASSERT_VAL("wrong exclude_hv", evsel->core.attr.exclude_hv); > - TEST_ASSERT_VAL("wrong exclude guest", evsel->core.attr.exclude_guest); > + TEST_ASSERT_VAL("wrong exclude guest", !evsel->core.attr.exclude_guest); > TEST_ASSERT_VAL("wrong exclude host", !evsel->core.attr.exclude_host); > TEST_ASSERT_VAL("wrong precise_ip", !evsel->core.attr.precise_ip); > TEST_ASSERT_VAL("wrong group name", !evsel->group_name); > @@ -1514,7 +1514,7 @@ static int test__leader_sample2(struct evlist *evlist __maybe_unused) > TEST_ASSERT_VAL("wrong exclude_user", !evsel->core.attr.exclude_user); > TEST_ASSERT_VAL("wrong exclude_kernel", evsel->core.attr.exclude_kernel); > TEST_ASSERT_VAL("wrong exclude_hv", evsel->core.attr.exclude_hv); > - TEST_ASSERT_VAL("wrong exclude guest", evsel->core.attr.exclude_guest); > + TEST_ASSERT_VAL("wrong exclude guest", !evsel->core.attr.exclude_guest); > TEST_ASSERT_VAL("wrong exclude host", !evsel->core.attr.exclude_host); > TEST_ASSERT_VAL("wrong precise_ip", !evsel->core.attr.precise_ip); > TEST_ASSERT_VAL("wrong group name", !evsel->group_name); > diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c > index f5eb1af8302c7bac..8d9e2d4b73822d98 100644 > --- a/tools/perf/util/parse-events.c > +++ b/tools/perf/util/parse-events.c > @@ -1761,7 +1761,7 @@ static int parse_events__modifier_list(struct parse_events_state *parse_state, > if (mod.user) { > if (!exclude) > exclude = eu = ek = eh = 1; > - if (!exclude_GH && !perf_guest) > + if (!exclude_GH && !perf_guest && exclude_HG_default) > eG = 1; > eu = 0; > } > diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c > index 9d55a13787ce3c05..7e3159faaa1991df 100644 > --- a/tools/perf/util/util.c > +++ b/tools/perf/util/util.c > @@ -78,17 +78,23 @@ bool sysctl__nmi_watchdog_enabled(void) > > bool test_attr__enabled; > > +bool exclude_HG_default; > + > bool perf_host = true; > bool perf_guest = false; > > void event_attr_init(struct perf_event_attr *attr) > { > + /* to capture ABI version */ > + attr->size = sizeof(*attr); > + > + if (!exclude_HG_default) > + return; > + > if (!perf_host) > attr->exclude_host = 1; > if (!perf_guest) > attr->exclude_guest = 1; > - /* to capture ABI version */ > - attr->size = sizeof(*attr); > } > > int mkdir_p(char *path, mode_t mode) > diff --git a/tools/perf/util/util.h b/tools/perf/util/util.h > index 9966c21aaf048479..d33ae883a54f2f2f 100644 > --- a/tools/perf/util/util.h > +++ b/tools/perf/util/util.h > @@ -21,6 +21,9 @@ extern const char perf_more_info_string[]; > > extern const char *input_name; > > +/* This will control if perf_{host,guest} will set attr.exclude_{host,guest}. */ > +extern bool exclude_HG_default; > + > extern bool perf_host; > extern bool perf_guest; >
Powered by blists - more mailing lists