linux-kernel - Re: [PATCH v2] selftests/timers: Remove unused NSEC_PER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49d07daa-622f-4c04-9d00-221f8abfb4f3@linuxfoundation.org>
Date: Fri, 6 Sep 2024 08:29:14 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: zhangjiao2 <zhangjiao2@...s.chinamobile.com>, jstultz@...gle.com
Cc: anna-maria@...utronix.de, frederic@...nel.org,
 linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
 shuah@...nel.org, tglx@...utronix.de, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2] selftests/timers: Remove unused NSEC_PER_SEC macro

On 9/5/24 20:52, zhangjiao2 wrote:
> From: zhang jiao <zhangjiao2@...s.chinamobile.com>
> 
> By readind the code, I found the macro NSEC_PER_SEC

reading

> is never referenced in the code. Just remove it.
> 
> Signed-off-by: zhang jiao <zhangjiao2@...s.chinamobile.com>

Running checkpatch can catch spelling errors.

> ---
> v1->v2:
> 	Put together files with similar problems
> 
>   tools/testing/selftests/timers/change_skew.c      | 3 ---
>   tools/testing/selftests/timers/skew_consistency.c | 2 --
>   2 files changed, 5 deletions(-)
> 
> diff --git a/tools/testing/selftests/timers/change_skew.c b/tools/testing/selftests/timers/change_skew.c
> index 4421cd562c24..18e794a46c23 100644
> --- a/tools/testing/selftests/timers/change_skew.c
> +++ b/tools/testing/selftests/timers/change_skew.c
> @@ -30,9 +30,6 @@
>   #include <time.h>
>   #include "../kselftest.h"
>   
> -#define NSEC_PER_SEC 1000000000LL
> -
> -
>   int change_skew_test(int ppm)
>   {
>   	struct timex tx;
> diff --git a/tools/testing/selftests/timers/skew_consistency.c b/tools/testing/selftests/timers/skew_consistency.c
> index c8e6bffe4e0a..83450145fe65 100644
> --- a/tools/testing/selftests/timers/skew_consistency.c
> +++ b/tools/testing/selftests/timers/skew_consistency.c
> @@ -36,8 +36,6 @@
>   #include <sys/wait.h>
>   #include "../kselftest.h"
>   
> -#define NSEC_PER_SEC 1000000000LL
> -
>   int main(int argc, char **argv)
>   {
>   	struct timex tx;

This looks good to me.

Reviewed-by: Shuah Khan <skhan@...uxfoundation.org>

John, I can pick this up with if you are okay with this change.

thanks,
-- Shuah