linux-kernel - Re: [PATCH 03/12] wifi: mwifiex: deduplicate code in mwifiex_cmd_tx_rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240906145400.GB45399@francesco-nb>
Date: Fri, 6 Sep 2024 16:54:00 +0200
From: Francesco Dolcini <francesco@...cini.it>
To: Sascha Hauer <s.hauer@...gutronix.de>
Cc: Brian Norris <briannorris@...omium.org>,
	Francesco Dolcini <francesco@...cini.it>,
	Kalle Valo <kvalo@...nel.org>, linux-wireless@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/12] wifi: mwifiex: deduplicate code in
 mwifiex_cmd_tx_rate_cfg()

On Mon, Aug 26, 2024 at 01:01:24PM +0200, Sascha Hauer wrote:
> The code block inside the if/else is the same with just using
> pbitmap_rates if non NULL or priv->bitmap_rates otherwise. Deduplicate
> the code by picking the correct pointer first and then using it
> unconditionally.
> 
> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>

Reviewed-by: Francesco Dolcini <francesco.dolcini@...adex.com>