linux-kernel - Re: [PATCH mm-unstable v1 3/3] mm/codetag: add pgalloc_tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJuCfpEfNVSH4R+2i+5tqXfvQRcEb-80vnKw37-oK-5X463sMA@mail.gmail.com>
Date: Thu, 5 Sep 2024 20:27:01 -0700
From: Suren Baghdasaryan <surenb@...gle.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: Yu Zhao <yuzhao@...gle.com>, Kent Overstreet <kent.overstreet@...ux.dev>, 
	Muchun Song <muchun.song@...ux.dev>, linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH mm-unstable v1 3/3] mm/codetag: add pgalloc_tag_copy()

On Thu, Sep 5, 2024 at 5:03 PM Suren Baghdasaryan <surenb@...gle.com> wrote:
>
> On Thu, Sep 5, 2024 at 4:25 PM Andrew Morton <akpm@...ux-foundation.org> wrote:
> >
> > On Tue,  3 Sep 2024 15:36:49 -0600 Yu Zhao <yuzhao@...gle.com> wrote:
> >
> > > Add pgalloc_tag_copy() to transfer the codetag from the old folio to
> > > the new one during migration. This makes original allocation sites
> > > persist cross migration rather than lump into compaction_alloc, e.g.,
> > >   # echo 1 >/proc/sys/vm/compact_memory
> > >   # grep compaction_alloc /proc/allocinfo
> > >
> > > Before this patch:
> > >   132968448  32463  mm/compaction.c:1880 func:compaction_alloc
> > >
> > > After this patch:
> > >           0      0  mm/compaction.c:1880 func:compaction_alloc
> > >
> >
> > I'm thinking that [2/3] should be backported?
>
> Yes, should be CC'ed to stable #6.10
>
> >
> > And possibly this one, but for that we should identify a Fixes:, please.
>
> I think for this one Fixes: dcfe378c81f7 ("lib: introduce support for
> page allocation tagging") would be the most appropriate.
>
> I'll review all 3 fixes later today.

Looks good to me. Both [2/3] and [3/3] should be sent to stable 6.10.

Acked-by: Suren Baghdasaryan <surenb@...gle.com>

> Thanks!