linux-kernel - Re: [PATCH 5/7] tracing: add config option for print arguments in ftrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <69b78634-3295-c22e-c09c-e41aa4554df3@huaweicloud.com>
Date: Fri, 6 Sep 2024 11:36:11 +0800
From: Zheng Yejian <zhengyejian@...weicloud.com>
To: Sven Schnelle <svens@...ux.ibm.com>, Steven Rostedt
 <rostedt@...dmis.org>, Masami Hiramatsu <mhiramat@...nel.org>,
 Mark Rutland <mark.rutland@....com>,
 Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Cc: linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH 5/7] tracing: add config option for print arguments in
 ftrace

On 2024/9/4 14:58, Sven Schnelle wrote:
> Add a config option to disable/enable function argument
> printing support during runtime.
> 
> Signed-off-by: Sven Schnelle <svens@...ux.ibm.com>
> ---
>   kernel/trace/Kconfig | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
> 
> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index 721c3b221048..8b9b6cdf39ac 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -242,6 +242,18 @@ config FUNCTION_GRAPH_RETVAL
>   	  enable it via the trace option funcgraph-retval.
>   	  See Documentation/trace/ftrace.rst
>   
> +config FUNCTION_TRACE_ARGS
> +	bool "Kernel Function Tracer Arguments"
> +	depends on HAVE_FUNCTION_ARG_ACCESS_API
> +	depends on DEBUG_INFO_BTF && BPF_SYSCALL

Nice feature!

Just a nit, DEBUG_INFO_BTF currently depends on BPF_SYSCALL,
so BPF_SYSCALL may not be necessary here. This feature
also doesn't seem to depend on bpf.

> +	default n
> +	help
> +	  Support recording and printing of function arguments when using
> +	  the function tracer or function graph tracer. This feature is off
> +	  by default, and can be enabled via the trace option func-args (for
> +	  the function tracer) and funcgraph-args (for the function graph
> +	  tracer).
> +
>   config DYNAMIC_FTRACE
>   	bool "enable/disable function tracing dynamically"
>   	depends on FUNCTION_TRACER

-- 
Thanks,
Zheng Yejian