lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20240906163118.GI2097826@kernel.org> Date: Fri, 6 Sep 2024 17:31:18 +0100 From: Simon Horman <horms@...nel.org> To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> Cc: Pablo Neira Ayuso <pablo@...filter.org>, Felix Huettner <felix.huettner@...l.schwarz>, netfilter-devel@...r.kernel.org, coreteam@...filter.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, llvm@...ts.linux.dev, Jozsef Kadlecsik <kadlec@...filter.org>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Nathan Chancellor <nathan@...nel.org>, Nick Desaulniers <ndesaulniers@...gle.com>, Bill Wendling <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com> Subject: Re: [PATCH net v1 1/1] netfilter: conntrack: Guard possoble unused functions On Fri, Sep 06, 2024 at 05:29:38PM +0100, Simon Horman wrote: > On Thu, Sep 05, 2024 at 11:36:12PM +0300, Andy Shevchenko wrote: ... > Hi Andy, > > Local testing seems to show that the warning is still emitted > for ctnetlink_label_size if CONFIG_NETFILTER_NETLINK_GLUE_CT is enabled > but CONFIG_NF_CONNTRACK_EVENTS is not. > > > > > Fix this by guarding possible unused functions with ifdeffery. > > > > See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static > > inline functions for W=1 build"). > > > > Fixes: 4a96300cec88 ("netfilter: ctnetlink: restore inlining for netlink message size calculation") > > I'm not sure that this qualifies as a fix, rather I think it should > be targeted at net-next without a Fixes tag. > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> > > ... Sorry, one more minor thing: possible is misspelt in the subject.
Powered by blists - more mailing lists