linux-kernel - Re: [RFC 00/31] objtool, livepatch: Livepatch module generation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240906170008.fc7h3vqdpwnkok3b@treble>
Date: Fri, 6 Sep 2024 10:00:08 -0700
From: Josh Poimboeuf <jpoimboe@...nel.org>
To: Joe Lawrence <joe.lawrence@...hat.com>
Cc: live-patching@...r.kernel.org, linux-kernel@...r.kernel.org,
	x86@...nel.org, Miroslav Benes <mbenes@...e.cz>,
	Petr Mladek <pmladek@...e.com>, Jiri Kosina <jikos@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Marcos Paulo de Souza <mpdesouza@...e.com>,
	Song Liu <song@...nel.org>
Subject: Re: [RFC 00/31] objtool, livepatch: Livepatch module generation

On Fri, Sep 06, 2024 at 09:56:06AM -0400, Joe Lawrence wrote:
> In the case of klp-diff.c, adding #include <string.h> will provide the
> memmem prototype.  For both files, I needed to #define _GNU_SOURCE for
> that prototype though.
> 
> For the other complaint, I just set struct instruction *dest_insn = NULL
> at the top of the for loop, but perhaps the code could be refactored to
> clarify the situation to the compiler if you prefer not to do that.

Thanks!  I'll get these fixed up.

-- 
Josh