linux-kernel - Re: [PATCH net-next v2] dt-bindings: net: ath11k: document the inputs of the ath11k on WCN6855

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e77b503-36ff-4a97-993b-f87d658c9970@quicinc.com>
Date: Fri, 6 Sep 2024 11:38:06 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Bartosz Golaszewski <brgl@...ev.pl>, Kalle Valo <kvalo@...nel.org>
CC: "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni
	<pabeni@...hat.com>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Jeff Johnson
	<jjohnson@...nel.org>, <linux-wireless@...r.kernel.org>,
        <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <ath11k@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        Bartosz
 Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH net-next v2] dt-bindings: net: ath11k: document the inputs
 of the ath11k on WCN6855

On 9/6/2024 12:44 AM, Bartosz Golaszewski wrote:
> For upstream - if you're using the WCN6855, you must specify the
> inputs for the WLAN module so it's only fair they be described as
> "required". For out-of-tree DTS I couldn't care less.
> 
> You are not correct saying that "M.2 boards don't need these" because
> as a matter of fact: the WLAN module on your M.2 card takes these
> inputs from the PMU inside the WCN6855 package.

Let me start by saying that DT is one area where I'm a newbie, so I hope I can
get some education.

I'd like to start with an observation: I've used both WCN6855 with ath11k and
WCN7850 with ath12k on an x86 laptop without any device tree, so from that
perspective none of the device tree stuff is "required" -- these modules "just
work".

However I also realize that when these are installed on Qualcomm ARM platforms
that there are GPIO pins that control things like XO clock, WLAN enable &
Bluetooth enable, as well as voltage regulators, and the device is
non-functional without those configured, so the device tree items are required
in that environment.

So just from that perspective saying something is "required" is confusing when
there are platforms where it isn't required. And perhaps that is what is
confusing Kalle as well?

/jeff