lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20240906190808.GL2097826@kernel.org> Date: Fri, 6 Sep 2024 20:08:08 +0100 From: Simon Horman <horms@...nel.org> To: Rohit Chavan <roheetchavan@...il.com> Cc: Johannes Berg <johannes@...solutions.net>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] lib80211: Use ERR_CAST() to return On Fri, Sep 06, 2024 at 05:14:55PM +0530, Rohit Chavan wrote: > Using ERR_CAST() is more reasonable and safer, When it is necessary > to convert the type of an error pointer and return it. > > Signed-off-by: Rohit Chavan <roheetchavan@...il.com> > --- > net/wireless/lib80211.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/wireless/lib80211.c b/net/wireless/lib80211.c > index d66a913027e0..87c0e09aa676 100644 > --- a/net/wireless/lib80211.c > +++ b/net/wireless/lib80211.c > @@ -227,7 +227,7 @@ EXPORT_SYMBOL(lib80211_get_crypto_ops); > > static void *lib80211_crypt_null_init(int keyidx) > { > - return (void *)1; > + return ERR_CAST(1); This seems wrong to me. ERR_CAST is designed to cast a pointer to an error pointer. But 1 is an integer, not a pointer. > } > > static void lib80211_crypt_null_deinit(void *priv) > -- > 2.34.1 > >
Powered by blists - more mailing lists