linux-kernel - Re: [PATCH v2] selftests/timers: Remove unused NSEC_PER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b84546c4-374a-457f-94ee-509db6fd0044@linuxfoundation.org>
Date: Fri, 6 Sep 2024 13:40:46 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: John Stultz <jstultz@...gle.com>
Cc: zhangjiao2 <zhangjiao2@...s.chinamobile.com>, anna-maria@...utronix.de,
 frederic@...nel.org, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org, shuah@...nel.org, tglx@...utronix.de,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2] selftests/timers: Remove unused NSEC_PER_SEC macro

On 9/6/24 11:02, John Stultz wrote:
> On Fri, Sep 6, 2024 at 7:29 AM Shuah Khan <skhan@...uxfoundation.org> wrote:
>> On 9/5/24 20:52, zhangjiao2 wrote:
>>> diff --git a/tools/testing/selftests/timers/skew_consistency.c b/tools/testing/selftests/timers/skew_consistency.c
>>> index c8e6bffe4e0a..83450145fe65 100644
>>> --- a/tools/testing/selftests/timers/skew_consistency.c
>>> +++ b/tools/testing/selftests/timers/skew_consistency.c
>>> @@ -36,8 +36,6 @@
>>>    #include <sys/wait.h>
>>>    #include "../kselftest.h"
>>>
>>> -#define NSEC_PER_SEC 1000000000LL
>>> -
>>>    int main(int argc, char **argv)
>>>    {
>>>        struct timex tx;
>>
>> This looks good to me.
>>
>> Reviewed-by: Shuah Khan <skhan@...uxfoundation.org>
>>
>> John, I can pick this up with if you are okay with this change.
> 
> No objection from me, if you're ok with the commit.
> Acked-by: John Stultz <jstultz@...gle.com>
> 
> thanks
> -john


Thank you. Applied linux-kselftest next for Linux 6.12-rc1.

thanks,
-- Shuah