linux-kernel - Re: [PATCH v3 07/12] arm64: dts: renesas: r9a08g045: Add VBATTB node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <951b5c09c3ca2de3f0a28a078084f7dd.sboyd@kernel.org>
Date: Fri, 06 Sep 2024 16:01:00 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: alexandre.belloni@...tlin.com, claudiu beznea <claudiu.beznea@...on.dev>, conor+dt@...nel.org, krzk+dt@...nel.org, magnus.damm@...il.com, mturquette@...libre.com, p.zabel@...gutronix.de, robh@...nel.org, linux-renesas-soc@...r.kernel.org, linux-clk@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-rtc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
Subject: Re: [PATCH v3 07/12] arm64: dts: renesas: r9a08g045: Add VBATTB node

Quoting Geert Uytterhoeven (2024-09-06 00:28:38)
> Hi Stephen,
> 
> On Thu, Sep 5, 2024 at 8:09 PM Stephen Boyd <sboyd@...nel.org> wrote:
> > Quoting claudiu beznea (2024-09-04 05:17:30)
> > > On 03.09.2024 22:48, Stephen Boyd wrote:
> > > > The node name should be something like clock-<frequency> but if the
> > > > frequency is different per-board then I don't know what should happen
> > > > here.
> > >
> > > The frequency should be always around 32768 Hz but not necessarily exactly
> > > 32768 Hz. It depends on what is installed on the board, indeed. RTC can do
> > > time error adjustments based on the variations around 32768 Hz.
> > >
> > > > Can you leave the vbattb_xtal phandle up above and then require
> > > > the node to be defined in the board with the proper frequency after the
> > > > dash?
> > >
> > > Is it OK for you something like this (applied on top of this series)?
> >
> > Yes, it's too bad we can't append to a property in DT, or somehow leave
> > alone certain cells and only modify one of them.
> 
> My main objections are that (1) this approach is different than the one used
> for all other external clock inputs on Renesas SoCs, and (2) this requires
> duplicating part of the clocks property in all board DTS files.
> 

Can 'clock-ranges' be used here? Leave the cell as null in the SoC dtsi
file and then fill it in with clocks property at the parent node. I
think you'd have to use clock-names for this though.