lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZtuPSIFsV8C3UZW8@bombadil.infradead.org> Date: Fri, 6 Sep 2024 16:24:56 -0700 From: Luis Chamberlain <mcgrof@...nel.org> To: Thomas Gleixner <tglx@...utronix.de> Cc: Jinjie Ruan <ruanjinjie@...wei.com>, linux-kernel@...r.kernel.org, "Peter Zijlstra (Intel)" <peterz@...radead.org>, Christophe Leroy <christophe.leroy@...roup.eu>, Josh Poimboeuf <jpoimboe@...nel.org>, Liu Shixin <liushixin2@...wei.com> Subject: Re: [PATCH] static_call: Handle module init failure correctly in static_call_del_module() On Thu, Sep 05, 2024 at 11:44:00AM +0200, Thomas Gleixner wrote: > Now you at least provided the information that the missing cleanup in > the init() function is not the problem. So the obvious place to look is > in the module core code whether there is a failure path _after_ > module->init() returned success. > > do_init_module() > ret = do_one_initcall(mod->init); > ... > ret = module_enable_rodata_ro(mod, true); > if (ret) > goto fail_mutex_unlock; > > and that error path does _not_ invoke module->exit(), which is obviously > not correct. Luis? You're spot on this needs fixing. Luis
Powered by blists - more mailing lists