linux-kernel - Re: [RESEND. PATCH v2] MIPS: crypto: Clean up useless assignment operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZtqZpzMH_qMQqzyc@gondor.apana.org.au>
Date: Fri, 6 Sep 2024 13:56:55 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: WangYuli <wangyuli@...ontech.com>
Cc: davem@...emloft.net, tsbogend@...ha.franken.de,
	linux-crypto@...r.kernel.org, linux-mips@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"Maciej W . Rozycki" <macro@...am.me.uk>,
	Guan Wentao <guanwentao@...ontech.com>
Subject: Re: [RESEND. PATCH v2] MIPS: crypto: Clean up useless assignment
 operations

On Fri, Sep 06, 2024 at 11:46:05AM +0800, WangYuli wrote:
>
> diff --git a/arch/mips/crypto/crc32-mips.c b/arch/mips/crypto/crc32-mips.c
> index ec6d58008f8e..3a80b7576ec3 100644
> --- a/arch/mips/crypto/crc32-mips.c
> +++ b/arch/mips/crypto/crc32-mips.c
> @@ -77,36 +77,29 @@ static u32 crc32_mips_le_hw(u32 crc_, const u8 *p, unsigned int len)
>  {
>  	u32 crc = crc_;
>  
> -#ifdef CONFIG_64BIT
> -	while (len >= sizeof(u64)) {
> +#if IS_ENABLED(CONFIG_64BIT)

That's not how we normally use IS_ENABLED.  The point of having
it is so that you can embed it into the C code directly, i.e.:

	if (IS_ENABLED(CONFIG_64BIT))

Please also refrain from making unrelated changes like removing
blank lines in the same patch as it makes it more difficult to
see what you're actually changing.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt