linux-kernel - Re: [PATCH 1/1] drivers: tty: imx: fix flags of rs485 not work properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7a31001d-da37-4deb-a366-084a4027bcd2@suse.cz>
Date: Fri, 6 Sep 2024 08:03:43 +0200
From: Jiri Slaby <jslaby@...e.cz>
To: shawnguo@...nel.org, LiangCheng Wang <zaq14760@...il.com>
Cc: s.hauer@...gutronix.de, gregkh@...uxfoundation.org,
 kernel@...gutronix.de, festevam@...il.com, u.kleine-koenig@...gutronix.de,
 cniedermaier@...electronics.com, l.sanfilippo@...bus.com,
 linux@...musvillemoes.dk, stefan.eichenberger@...adex.com,
 tglx@...utronix.de, rickaran@...s.com, linux-kernel@...r.kernel.org,
 linux-serial@...r.kernel.org, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/1] drivers: tty: imx: fix flags of rs485 not work
 properly

It seems gmail refuses to send this to zaq14760@...il.com (the author).

On 06. 09. 24, 4:19, LiangCheng Wang wrote:
> The rs485.flags are lost in functions such as imx_uart_stop_tx(),
> causing the function of RS485 to be invalid when using the
> serial port as the RS485 port. Use a variable to store the state to
> avoid this issue.

AFAICT, this feels rather wrong. Any rs485 experts around?

At minimum, how are the flags "lost" and why this does not matter to 
other drivers?

> --- a/drivers/tty/serial/imx.c
> +++ b/drivers/tty/serial/imx.c
> @@ -209,7 +209,7 @@ struct imx_port {
>   	const struct imx_uart_data *devdata;
>   
>   	struct mctrl_gpios *gpios;
> -
> +	int flags;

Definitely not int for flags.

thanks,
-- 
js
suse labs