linux-kernel - RE: [PATCH net-next 0/3] lan743x: This series of patches are for lan743x driver testing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DM6PR11MB4236D1B92E9FDF1A4640DA68839E2@DM6PR11MB4236.namprd11.prod.outlook.com>
Date: Fri, 6 Sep 2024 06:45:53 +0000
From: <Mohan.Prasad@...rochip.com>
To: <andrew@...n.ch>
CC: <netdev@...r.kernel.org>, <davem@...emloft.net>, <kuba@...nel.org>,
	<shuah@...nel.org>, <Bryan.Whitehead@...rochip.com>,
	<UNGLinuxDriver@...rochip.com>, <edumazet@...gle.com>, <pabeni@...hat.com>,
	<linux-kernel@...r.kernel.org>, <linux-kselftest@...r.kernel.org>,
	<horms@...nel.org>, <brett.creeley@....com>, <rosenp@...il.com>
Subject: RE: [PATCH net-next 0/3] lan743x: This series of patches are for
 lan743x driver testing

Hello Andrew,

Thank you for your review comments.

> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> On Wed, Sep 04, 2024 at 03:45:46AM +0530, Mohan Prasad J wrote:
> > This series of patches are for testing the lan743x network driver.
> > Testing comprises autonegotiation, speed, duplex and throughput checks.
> > Tools such as ethtool, iperf3 are used in the testing process.
> > Performance test is done for TCP streams at different speeds.
> 
> What is specific to lan743x? Why won't the autoneg test work for any
> interface which says it supports autoneg? Is duplex somehow special on the
> lan743x?
> 
> Where possible, please try to make these tests generic, usable on any NIC. Or
> clearly document why they cannot be generic.
> 

As suggested, I will change the testcases to generic form and document them accordingly in the next version.

>         Andrew