lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <33cb57cd-200b-48a7-9028-3f6bf46b4dde@amd.com> Date: Fri, 6 Sep 2024 09:05:01 +0200 From: Michal Simek <michal.simek@....com> To: Min-Hua Chen <minhuadotchen@...il.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby <jirislaby@...nel.org> Cc: linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH] serial: xilinx_uartps: make cdns_rs485_supported static On 9/6/24 01:19, Min-Hua Chen wrote: > make cdns_rs485_supported static to fix the following sparse > warning: > > drivers/tty/serial/xilinx_uartps.c:222:21: sparse: warning: > symbol 'cdns_rs485_supported' was not declared. Should it be static? > > Signed-off-by: Min-Hua Chen <minhuadotchen@...il.com> > --- > drivers/tty/serial/xilinx_uartps.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c > index 2acfcea403ce..777392914819 100644 > --- a/drivers/tty/serial/xilinx_uartps.c > +++ b/drivers/tty/serial/xilinx_uartps.c > @@ -219,7 +219,7 @@ struct cdns_platform_data { > u32 quirks; > }; > > -struct serial_rs485 cdns_rs485_supported = { > +static struct serial_rs485 cdns_rs485_supported = { > .flags = SER_RS485_ENABLED | SER_RS485_RTS_ON_SEND | > SER_RS485_RTS_AFTER_SEND, > .delay_rts_before_send = 1, This has been applied already as commit 68c5efd9dca ("serial: xilinx_uartps: Make cdns_rs485_supported static"). You can also see it here https://lore.kernel.org/r/20240819120107.3884973-1-ruanjinjie@huawei.com Thanks, Michal
Powered by blists - more mailing lists